Adds contribution queue (uplift to 0.72.x) #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
kylehickinson,
NejcZdovc and
tmancey
as code owners
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
kylehickinson
approved these changes
Oct 17, 2019
NejcZdovc
force-pushed
the
pr3658_recurring-tips_0.72.x
branch
from
9cfe33b
to
992fcaf
Compare
|
CI is ok as it only failed on |
kjozwiak
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Looks like CI/Jenkins mostly passed other than the dist failure @NejcZdovc mentioned as per #3728 (comment). @LaurenWags also spent some time QAing/making sure the PR works as per #3658 (comment).
Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #3658
Uplift of #3716
Approved, please ensure that before merging:
After you merge: