Fixes Already sustaining ad notification interaction is shown for conversion of the second ad within the same creative set
#4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/8634
branch
2 times, most recently
from
e14748b
to
7b49f89
Compare
tmancey
added
CI/skip-android
|
Passed on macOS, Windows, Android, iOS. Failed on Linux, restarting Linux |
NejcZdovc
reviewed
Mar 13, 2020
| @@ -1784,12 +1784,17 @@ void AdsImpl::SustainAdNotificationInteractionIfNeeded() { | |||
| BLOG(INFO) << "Failed to sustain ad notification interaction, domain for " | |||
| "the focused tab does not match the last shown ad notification for " | |||
| << last_shown_ad_notification_.target_url; | |||
|
|
|||
| last_sustained_ad_notification_url_ = ""; | |||
There was a problem hiding this comment.
could this be moved at the top of SustainAdNotificationInteractionIfNeeded, so that we don't need to do it twice? As far as I can see all paths set this
There was a problem hiding this comment.
ah yes, was put here originally as I was resetting last_shown_ad_notification_ which was needed here. Changing now
…onversion of the second ad within the same creative set
NejcZdovc
reviewed
Mar 13, 2020
| if (!IsStillViewingAdNotification()) { | ||
| BLOG(INFO) << "Failed to sustain ad notification interaction, domain for " | ||
| "the focused tab does not match the last shown ad notification for " | ||
| << last_shown_ad_notification_.target_url; | ||
|
|
NejcZdovc
approved these changes
Mar 13, 2020
|
Unrelated CI lint error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8634
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#8634 however if the same ad already exists landed confirmations will not occur and is covered by brave/brave-browser#5949
Reviewer Checklist:
After-merge Checklist:
changes has landed on.