Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored supported regions, large anonymity country codes and other country codes to use std::set #5443

Merged
merged 1 commit into from
May 4, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 1, 2020

Resolves brave/brave-browser#9205

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey
Copy link
Collaborator Author

tmancey commented May 3, 2020

Windows x64 failed CI, restarting

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 3, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented May 4, 2020

CI passed at https://ci.brave.com/job/pr-brave-browser-issues-9205/2/ (so not sure why the PR does not reflect this...)

@tmancey tmancey merged commit 420271a into master May 4, 2020
@tmancey tmancey deleted the issues/9205 branch May 4, 2020 13:12
@tmancey tmancey added this to the 1.10.x - Nightly milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor supported regions, large anonymity country codes and other country codes to use std::set
2 participants