Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n for Chromium 83 (1.11.x). #5800

Merged
merged 1 commit into from
Jun 10, 2020
Merged

L10n for Chromium 83 (1.11.x). #5800

merged 1 commit into from
Jun 10, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 9, 2020

Fixes brave/brave-browser#10120
Uplift from #5756

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.11.x - Beta milestone Jun 9, 2020
@mkarolin mkarolin requested a review from a team June 9, 2020 21:52
@mkarolin mkarolin requested a review from NejcZdovc as a code owner June 9, 2020 21:52
@mkarolin mkarolin self-assigned this Jun 9, 2020
@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-maxk-cr83-l10n-1.11.x/1/execution/node/423/log/.

19:29:05  FAILED: obj/brave/browser/brave_wallet/brave_wallet/brave_wallet_delegate_impl.o 

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 10, 2020
@kjozwiak
Copy link
Member

Restarting macOS due to init failing as per https://ci.brave.com/job/pr-brave-browser-maxk-cr83-l10n-1.11.x/2/execution/node/298/log/.

@kjozwiak
Copy link
Member

@mkarolin mind taking a look? Seems like init keeps failing on macOS.

@mkarolin
Copy link
Collaborator Author

Rebased on the latest 1.11.x branch

@kjozwiak
Copy link
Member

kjozwiak commented Jun 10, 2020

Thanks @mkarolin. Looks like test-install failed due to brave/brave-browser#9480 as per https://ci.brave.com/job/pr-brave-browser-maxk-cr83-l10n-1.11.x/5/execution/node/376/log/. However, this is a known issue and not related to this specific PR hence not blocking uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. Remaining failures are known and not blocking uplift as per #5800 (comment).

@kjozwiak kjozwiak merged commit d48820d into 1.11.x Jun 10, 2020
@kjozwiak kjozwiak deleted the maxk-cr83-l10n-1.11.x branch June 10, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants