Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17901 - Claim endpoint for gemini needs a deposit address #9544

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix #17901 - Claim endpoint for gemini needs a deposit address #9544

merged 1 commit into from
Jul 28, 2021

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Jul 22, 2021 •
edited
Loading

Resolves brave/brave-browser#17091

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Verify user-drain works with Gemini

@jumde jumde force-pushed the claim_with_recipient_id branch 2 times, most recently from 160faa4 to a4be47a Compare July 23, 2021 00:48
@jumde jumde marked this pull request as ready for review July 26, 2021 16:07
@jumde jumde requested a review from a team as a code owner July 26, 2021 16:07
@jumde jumde changed the title [WIP] Fix #17901 - Claim endpoint for gemini needs a deposit address Fix #17901 - Claim endpoint for gemini needs a deposit address Jul 26, 2021
zenparsing
zenparsing reviewed Jul 26, 2021
View reviewed changes
...-ledger/src/bat/ledger/internal/endpoint/gemini/post_recipient_id/post_recipient_id_gemini.h Outdated
using PostRecipientIdCallback =
std::function<void(const type::Result result,
const std::string recipient_id,
const std::string token)>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the caller supplies token, does the caller need to receive it in the callback as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

...ledger/src/bat/ledger/internal/endpoint/gemini/post_recipient_id/post_recipient_id_gemini.cc Outdated
base::JSONWriter::Write(payload, &json);

std::string base64;
base::Base64Encode(base::StringPiece(json), &base64);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think std::string will implicitly convert to StringPiece; if so, the explicit StringPiece constructor call isn't necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

...-ledger/src/bat/ledger/internal/endpoint/gemini/post_recipient_id/post_recipient_id_gemini.h Outdated

using PostRecipientIdCallback =
std::function<void(const type::Result result,
const std::string recipient_id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter should be const std::string& for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

jumde
jumde commented Jul 26, 2021
View reviewed changes
...c/bat/ledger/internal/endpoint/gemini/post_recipient_id/post_recipient_id_gemini_unittest.cc Outdated

post_recipient_id_->Request(
"4c2b665ca060d912fec5c735c734859a06118cc8",
[](const type::Result result, const std::string recipient_id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing

emerick
emerick approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumde jumde mentioned this pull request Jul 28, 2021
Closed
@jumde jumde merged commit cafeff4 into master Jul 28, 2021
@jumde jumde deleted the claim_with_recipient_id branch July 28, 2021 21:06
@jumde jumde added this to the 1.29.x - Nightly milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@zenparsing zenparsing zenparsing approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging this pull request may close these issues.

Claim endpoint for gemini needs a deposit address
3 participants
@jumde @emerick @zenparsing