This repository has been archived by the owner on May 13, 2024. It is now read-only.
make sync images exportable #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
approved these changes
Dec 6, 2018
src/features/sync/images/index.ts
Outdated
| import RemoveIconImage from './remove_icon.svg' | ||
| import DesktopImage from './desktop_icon.svg' | ||
| import MobilePicture from './mobile_icon.svg' | ||
| import MobilePictureImage from './mobile_picture.png' |
There was a problem hiding this comment.
nit: there'd be less confusion in this module of variable names if the urls ended in Url and the actual image elements ended in Image (or Icon or Picture I guess). But at the moment they are mixed - some urls end in Picture and some components end in Picture, etc.
There was a problem hiding this comment.
k added the url suffix and normalized them to use image instead of icon/picture
cezaraugusto
force-pushed
the
sync_img
branch
from
be951d1
to
c30edea
Compare
cezaraugusto
force-pushed
the
sync_img
branch
from
c30edea
to
470233f
Compare
cezaraugusto
added a commit
that referenced
this pull request
Dec 10, 2018
make sync images exportable
cezaraugusto
added a commit
that referenced
this pull request
Dec 10, 2018
make sync images exportable
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
This reverts commit 2c16ae2.
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
This reverts commit 69ef8be.
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
make sync images exportable
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
make sync images exportable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses partial feedback from brave/brave-core#1019