Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Don't use the previous URL if current virtual URL is safebrowsing
Browse files Browse the repository at this point in the history
Fixes #10143

Auditors: @diracdeltas, @alexwykoff

Test Plan:
1. open new tab
2. navigate to downloadme.org
3. notice that URL is properly "about:safebrowsing#downloadme.org"
  • Loading branch information
bsclifton committed Jul 26, 2017
1 parent 1eefa1a commit 450cc5c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/browser/tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ const fixDisplayURL = (navigationEntry, controller) => {
navigationEntry.virtualURL = getSourceAboutUrl(navigationEntry.virtualURL)
}

if (isIntermediateAboutPage(navigationEntry.virtualURL)) {
if (isIntermediateAboutPage(navigationEntry.virtualURL) &&
!navigationEntry.virtualURL.startsWith('about:safebrowsing#')) {
const previousEntry = controller.getEntryAtOffset(-1)
if (!controller.canGoForward() && previousEntry) {
navigationEntry.virtualURL = previousEntry.virtualURL
Expand Down

0 comments on commit 450cc5c

Please sign in to comment.