Fix sending messages in hangouts on gmail

Test Plan: Run the STR in the issue on both inbox.google.com and mail.google.com

Fix #3703

Auditors: @bridiver

app/siteHacks.js

@@ -6,7 +6,7 @@
 
 const URL = require('url')
 const Filtering = require('./filtering')
-const siteHacks = require('../js/data/siteHacks')
+const {siteHacks} = require('../js/data/siteHacks')
 const appConfig = require('../js/constants/appConfig')
 
 const resourceName = 'siteHacks'

js/components/frame.js

@@ -15,7 +15,7 @@ const FrameStateUtil = require('../state/frameStateUtil')
 const UrlUtil = require('../lib/urlutil')
 const messages = require('../constants/messages.js')
 const contextMenus = require('../contextMenus')
-const siteHacks = require('../data/siteHacks')
+const {siteHacks} = require('../data/siteHacks')
 const ipc = global.require('electron').ipcRenderer
 const clipboard = global.require('electron').clipboard
 const FullScreenWarning = require('./fullScreenWarning')

js/data/siteHacks.js

@@ -20,7 +20,16 @@ const emptyDataURI = {
   }
 }
 
-module.exports = {
+/**
+ * Holds an array of [Primary URL, subresource URL] to allow 3rd party cookies for.
+ * Subresource URL can be '*' or undefined to indicate all.
+ */
+module.exports.cookieExceptions = [
+  ['https://inbox.google.com', 'https://hangouts.google.com'],
+  ['https://mail.google.com', 'https://hangouts.google.com']
+]
+
+module.exports.siteHacks = {
   'sp1.nypost.com': emptyDataURI,
   'sp.nasdaq.com': emptyDataURI,
   'forbes.com': {

js/state/contentSettings.js

@@ -8,6 +8,7 @@ const AppConstants = require('../constants/appConstants')
 const appConfig = require('../constants/appConfig')
 const config = require('../constants/config')
 const settings = require('../constants/settings')
+const {cookieExceptions} = require('../data/siteHacks')
 const {passwordManagers, defaultPasswordManager} = require('../constants/passwordManagers')
 const urlParse = require('url').parse
 const siteSettings = require('./siteSettings')
@@ -137,6 +138,8 @@ const getContentSettingsFromSiteSettings = (appState) => {
         addContentSettings(contentSettings.cookies, hostPattern, '*', 'block')
         addContentSettings(contentSettings.cookies, hostPattern, parseSiteSettingsPattern(hostPattern), 'allow')
         addContentSettings(contentSettings.referer, hostPattern, '*', 'block')
+        cookieExceptions.forEach((exceptionPair) =>
+          addContentSettings(contentSettings.cookies, exceptionPair[0], exceptionPair[1], 'allow'))
       } else {
         addContentSettings(contentSettings.cookies, hostPattern, '*', 'allow')
         addContentSettings(contentSettings.referer, hostPattern, '*', 'allow')