Selecting cut text from context menu refills URL into URL bar Fixes #…

…5063
brave · Oct 24, 2016 · a32f948 · a32f948
1 parent 8b00d06
commit a32f948
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/js/components/urlBar.js b/js/components/urlBar.js
@@ -45,7 +45,7 @@ class UrlBar extends ImmutableComponent {
     this.searchSelectEntry = null
     this.keyPressed = false
     this.showAutocompleteResult = debounce(() => {
-      if (!this.urlInput || this.keyPressed) {
+      if (!this.urlInput || this.keyPressed || this.locationValue.length === 0) {
         return
       }
       const suffixLen = this.props.locationValueSuffix.length
@@ -102,6 +102,7 @@ class UrlBar extends ImmutableComponent {
       windowActions.setUrlBarAutocompleteEnabled(false)
     }
     windowActions.setUrlBarSuggestions(undefined, null)
+    windowActions.setRenderUrlBarSuggestions(false)
   }
 
   onKeyDown (e) {

diff --git a/js/stores/windowStore.js b/js/stores/windowStore.js
@@ -569,6 +569,10 @@ const doAction = (action) => {
     case WindowConstants.WINDOW_SET_RENDER_URL_BAR_SUGGESTIONS:
       windowState = windowState.setIn(activeFrameStatePath().concat(['navbar', 'urlbar', 'suggestions', 'shouldRender']), action.enabled)
       if (!action.enabled) {
+        windowState = windowState.mergeIn(activeFrameStatePath().concat(['navbar', 'urlbar', 'suggestions']), {
+          selectedIndex: null,
+          suggestionList: null
+        })
         // Make sure to remove the suffix from the url bar
         windowState = windowState.setIn(activeFrameStatePath().concat(['navbar', 'urlbar', 'suggestions', 'selectedIndex']), null)
         updateUrlSuffix(undefined)