Add fist entry focus test

Auditors: @kumarrishav, @bsclifton
brave · May 3, 2017 · d1f502a · d1f502a
1 parent a800fdb
commit d1f502a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/app/renderer/components/autofill/autofillCreditCardPanel.js b/app/renderer/components/autofill/autofillCreditCardPanel.js
@@ -115,6 +115,7 @@ class AutofillCreditCardPanel extends ImmutableComponent {
                   commonFormStyles.input__box,
                   styles.input
                 )}
+                  data-test-id='creditCardName'
                   spellCheck='false'
                   onKeyDown={this.onKeyDown}
                   onChange={this.onNameChange}
@@ -126,6 +127,7 @@ class AutofillCreditCardPanel extends ImmutableComponent {
                 className={css(commonFormStyles.input__marginRow)
               }>
                 <CommonFormTextbox
+                  data-test-id='creditCardNumber'
                   spellCheck='false'
                   onKeyDown={this.onKeyDown}
                   onChange={this.onCardChange}

diff --git a/test/contents/autofillTest.js b/test/contents/autofillTest.js
@@ -44,7 +44,7 @@ describe('Autofill', function () {
         .click(addAddressButton)
         .windowByUrl(Brave.browserWindowUrl)
         .waitForVisible(autofillAddressPanel)
-        .click('[data-test-id="nameOnAddress"]')
+        .waitForElementFocus('[data-test-id="nameOnAddress"]')
         .keys(name)
         .click('[data-test-id="organization"]')
         .keys(organization)
@@ -189,9 +189,9 @@ describe('Autofill', function () {
         .click(addCreditCardButton)
         .windowByUrl(Brave.browserWindowUrl)
         .waitForVisible(autofillCreditCardPanel)
-        .click('[data-test-id="creditCardNameWrapper"]')
+        .waitForElementFocus('[data-test-id="creditCardName"]')
         .keys(cardName)
-        .click('[data-test-id="creditCardNumberWrapper"]')
+        .click('[data-test-id="creditCardNumber"]')
         .keys(cardNumber)
         .selectByValue('[data-test-id="expMonthSelect"]', expMonth < 10 ? '0' + expMonth.toString() : expMonth.toString())
         .selectByValue('[data-test-id="expYearSelect"]', expYear.toString())
@@ -252,10 +252,10 @@ describe('Autofill', function () {
         .click('[data-test-id="EditCreditCard"]')
         .windowByUrl(Brave.browserWindowUrl)
         .waitForVisible(autofillCreditCardPanel)
-        .click('[data-test-id="creditCardNameWrapper"]')
+        .waitForElementFocus('[data-test-id="creditCardName"]')
         .keys(Brave.keys.END)
         .keys('123')
-        .click('[data-test-id="creditCardNumberWrapper"]')
+        .click('[data-test-id="creditCardNumber"]')
         .keys(Brave.keys.END)
         .keys('123')
         .selectByValue('[data-test-id="expMonthSelect"]', (expMonth + 1).toString())
@@ -311,7 +311,7 @@ describe('Autofill', function () {
         .click(addAddressButton)
         .windowByUrl(Brave.browserWindowUrl)
         .waitForVisible(autofillAddressPanel)
-        .click('[data-test-id="nameOnAddress"]')
+        .waitForElementFocus('[data-test-id="nameOnAddress"]')
         .keys(name)
         .click('[data-test-id="organization"]')
         .keys(organization)
@@ -341,9 +341,9 @@ describe('Autofill', function () {
         .click(addCreditCardButton)
         .windowByUrl(Brave.browserWindowUrl)
         .waitForVisible(autofillCreditCardPanel)
-        .click('[data-test-id="creditCardNameWrapper"]')
+        .waitForElementFocus('[data-test-id="creditCardName"]')
         .keys(cardName)
-        .click('[data-test-id="creditCardNumberWrapper"]')
+        .click('[data-test-id="creditCardNumber"]')
         .keys(cardNumber)
         .selectByValue('[data-test-id="expMonthSelect"]', expMonth < 10 ? '0' + expMonth.toString() : expMonth.toString())
         .selectByValue('[data-test-id="expYearSelect"]', expYear.toString())