Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Use a different socks port number for channel ''.
Browse files Browse the repository at this point in the history
Channel '' apparently happens for local builds, and we don't want it
to step on the toes of release builds.

fix #14592

This is a stop-gap measure until we use an OS-chosen socks port
number or a local socket as in #12936.

Auditors: @diracdeltas @bsclifton

Test Plan:
1. Launch a local development build of Brave.
2. Laucnh a release build of Brave.
3. Confirm that Tor works in both.
  • Loading branch information
riastradh-brave committed Jun 28, 2018
1 parent 5108937 commit e948fa3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/channel.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ exports.getTorSocksProxy = () => {
let portno
switch (channel) {
case 'dev':
case '':
default:
portno = 9250
break
Expand All @@ -80,6 +79,9 @@ exports.getTorSocksProxy = () => {
case 'developer':
portno = 9280
break
case '':
portno = 9290
break
}
return `socks5://127.0.0.1:${portno}`
}

0 comments on commit e948fa3

Please sign in to comment.