Load non-webview URLs in non-persistent session

Otherwise, favicon and search autocomplete URLs are always written to the userData cache, causing leakage of private browsing activity. Fix #138 Auditors: @bbondy
brave · Jan 26, 2016 · f021a9f · bbondy · Jan 26, 2016 · bbondy
1 parent 55d5118
commit f021a9f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/app/filtering.js b/app/filtering.js
@@ -72,6 +72,7 @@ module.exports.isThirdPartyHost = (baseContextHost, testHost) => {
 module.exports.init = () => {
   registerForSession(session.fromPartition(''))
   registerForSession(session.fromPartition('private-1'))
+  registerForSession(session.fromPartition('main-1'))
 }
 
 module.exports.isResourceEnabled = (resourceName) => {

diff --git a/app/httpsEverywhere.js b/app/httpsEverywhere.js
@@ -267,5 +267,6 @@ module.exports.init = () => {
   DataFile.init(module.exports.resourceName, startHttpsEverywhere, loadRulesets)
   registerForSession(session.fromPartition(''))
   registerForSession(session.fromPartition('private-1'))
+  registerForSession(session.fromPartition('main-1'))
 }
 
diff --git a/js/stores/appStore.js b/js/stores/appStore.js
@@ -146,7 +146,8 @@ function windowDefaults () {
     minModalWidth: 100,
     windowOffset: 20,
     webPreferences: {
-      sharedWorker: true
+      sharedWorker: true,
+      partition: 'main-1'
     }
   }
 }

diff --git a/package.json b/package.json
@@ -38,6 +38,10 @@
     {
       "name": "Brian Johnson",
       "email": "bjohnson@brave.com"
+    },
+    {
+      "name": "Yan Zhu",
+      "email": "yan@brave.com"
     }
   ],
   "license": "MPL-2.0",