Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about favicons are taking up way too much space in the session store #10000

Closed
bridiver opened this issue Jul 16, 2017 · 1 comment · Fixed by #10001
Closed

about favicons are taking up way too much space in the session store #10000

bridiver opened this issue Jul 16, 2017 · 1 comment · Fixed by #10001

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jul 16, 2017

Test plan

#10001 (comment)

  1. Fresh profile
  2. Open about:preferences, about:history and about:bookmarks
  3. Close Brave
  4. Open session-store-1 file in notepad, vim, etc
  5. Confirm about page entries are NOT saving favicon using the data URL syntax for their favicon

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    A fresh profile that opens about:preferences, about:history and about:bookmarks is ~180K

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Fresh profile
    2. Open about:preferences, about:history and about:bookmarks
    3. Close Brave
  • Actual result:
    session store is huge
    If you open the session-store-1 file, you WILL see about pages using the data URL syntax for their favicon.

  • Expected result:
    session store should not be huge
    If you open the session-store-1 file, you WON'T see about pages using the data URL syntax for their favicon.

@NejcZdovc
Copy link
Contributor

congrats on 10000 issue 🎉 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.