Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tab will not display #10122

Closed
darkdh opened this issue Jul 25, 2017 · 5 comments · Fixed by #10124
Closed

pinned tab will not display #10122

darkdh opened this issue Jul 25, 2017 · 5 comments · Fixed by #10124
Assignees
@darkdh
Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include
Milestone
0.18.23 Hotfix

Comments

@darkdh
Copy link
Member

darkdh commented Jul 25, 2017 •
edited
Loading

Test plan

  1. Use the session attached in pinned tab will not display #10122 (comment)
  2. Launch Brave
  3. Pin any tab
  4. Relaunch Brave
  5. Ensure the pinned tab shows up

Original issue

Performing the above steps WITHOUT the fix will cause an error:

TypeError: Cannot read property 'includes' of undefined
    at state.get.toList.filter (/Users/darkdh/Projects/browser-laptop/app/browser/windows.js:74:28)
...

cause by a site entry
"https://smile.amazon.com/gp/buy/spc/handlers/display.html?hasWorkingJavascript=1%7C0%7C0":{"favicon":"https://smile.amazon.com/favicon.ico"}
@darkdh darkdh self-assigned this Jul 25, 2017
@darkdh darkdh added this to the 0.20.x (Nightly Channel) milestone Jul 25, 2017
darkdh added a commit that referenced this issue Jul 25, 2017
@darkdh
Check tags before using them
047a869 
fix #10122

Auditors: @bsclifton

Test Plan:
@darkdh darkdh mentioned this issue Jul 25, 2017
Merged
8 tasks
@NejcZdovc
Copy link
Contributor

@darkdh tags will be deprecated in 0.20.x with my split sites PR

@NejcZdovc
Copy link
Contributor

So just a heads up if you targeting this for 0.20.x as well

@darkdh darkdh modified the milestones: 0.19.x (Developer Channel), 0.20.x (Nightly Channel) Jul 26, 2017
@darkdh
Copy link
Member Author

darkdh commented Jul 26, 2017

Thanks for the heads up. Changing it to 0.19.x before your PR landed

@darkdh darkdh mentioned this issue Jul 27, 2017
Closed
@bsclifton bsclifton modified the milestones: 0.18.x Hotfix, 0.19.x (Developer Channel) Jul 27, 2017
@bsclifton
Copy link
Member

This is kind of an anomaly case... @darkdh do you mind writing up some manual QA steps and/or creating a sample session file (and attaching) for QA to use?

@darkdh
Copy link
Member Author

darkdh commented Jul 31, 2017

Please use attached session file to test. Thanks
session-store-1.zip

This was referenced Aug 7, 2017
Closed
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Aug 9, 2017
Closed
This was referenced Aug 10, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Aug 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.23 Hotfix
Development

Successfully merging a pull request may close this issue.

Check tags before using them brave/browser-laptop
7 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @darkdh @srirambv @LaurenWags