This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix issue where pinned tab can't be really unpinned #10241
Assignees
Labels
Milestone
Comments
darkdh
added a commit
that referenced
this issue
Aug 3, 2017
also normalize site key without trailing slash fix #10241 Auditors: @bsclifton, @bbondy Test Plan: 1. Go to feedly.com 2. Pin the tab 3. Bookmark it and change the location to https://feedly.com 4. Unpin the pinned tab 5. Relaunch Brave 6. There shouldn't be any pinned tab
8 tasks
darkdh
added a commit
that referenced
this issue
Aug 3, 2017
also normalize site key without trailing slash fix #10241 Auditors: @bsclifton, @bbondy Test Plan: 1. Go to feedly.com 2. Pin the tab 3. Bookmark it and change the location to https://feedly.com 4. Unpin the pinned tab 5. Relaunch Brave 6. There shouldn't be any pinned tab
darkdh
added a commit
that referenced
this issue
Aug 3, 2017
also normalize site key without trailing slash fix #10241 Auditors: @bsclifton, @bbondy Test Plan: 1. Go to feedly.com 2. Pin the tab 3. Bookmark it and change the location to https://feedly.com 4. Unpin the pinned tab 5. Relaunch Brave 6. There shouldn't be any pinned tab
bsclifton
pushed a commit
that referenced
this issue
Aug 7, 2017
also normalize site key without trailing slash fix #10241 Auditors: @bsclifton, @bbondy Test Plan: 1. Go to feedly.com 2. Pin the tab 3. Bookmark it and change the location to https://feedly.com 4. Unpin the pinned tab 5. Relaunch Brave 6. There shouldn't be any pinned tab
8 tasks
bsclifton
changed the title
|
Fixed with #10326 |
This was referenced Aug 9, 2017
This was referenced Aug 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test Plan
Original issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Pinned tabs reappear next load after unpinning
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
526dc49
Steps to reproduce:
https://feedly.comActual result:
There shouldn't be any pinned feedly tab
Expected result:
The tab is still there
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
Pinned tabs reappear next load after unpinning #8477
cc @bsclifton
The text was updated successfully, but these errors were encountered: