Copying from Brave intermittently doesn't work, restart fixes.

[alex-wilmer]

Any text I copy from a webpage does not get added to my clipboard. I can copy the url from the address bar but not any page content.

Yosemite 10.10.5, macbook pro

[bbondy]

Which page? I'm copying text from your comment above OK. I think I have seen this before though and am not sure how to reproduce.

[alex-wilmer]

Doesn't look like any of them.. I noticed because I was trying to copy a branch name from github, but just checked reddit and can't copy anything from there either.

Version: 0.8.0
Electron: 0.36.8
libchromiumcontent: 47.0.2526.110
Channel: dev

I could make a video out of it if that helps. I'm also a JS / React developer so I can work on this over the weekend.

[bbondy]

that'd be great, I have seen this before but it's working now so it's intermittent. If you close your browser and re-open it might go away.

[alex-wilmer]

Ah restarting fixed this indeed. Any idea why?

[bbondy]

no but if you find something that triggers it pls let me know! Command+Alt+J gives you the browser level dev tools (+I gives you the per web page one). Next time you're in that state maybe you could poke around and try things.

[bbondy]

I'll attempt a fix for 0.8.1 but not sure if it'll work or not.

[alex-wilmer]

Ah thanks! I was looking for those dev tools! I've been using Brave for a few hours now and thought to myself.. "funny, I can't dock the dev tools!".

I'll go through the Readme and any developer docs after work.

[bbondy]

You can only doc the browser level ones due to a limitation in electron, we'll fix it in electron when we have a bit more time so you can doc the more common content level dev tools too.

[bbondy]

If you see this in 0.8.1 please comment here and we'll re-open.

[bbondy]

This is still an intermittent issue so re-opening.

[bbondy]

We need to find more information about how to reproduce this, or investigate while it's reproduced to get it fixed.

[bbondy]

Had this happen again, adding another observation:
When Command+C (Control+C) doesn't work you can right click on the text and select Copy on the context menu. That copies the text successfully and also makes the copy of selected text work again from Command+C.

[bbondy]

Had this happen again, got a lot more info:

Opening dev tools this works:
var clipboard = require('electron').clipboard;
clipboard.writeText('test')
Successfully copies text to the clipboard but the problem persists

Selecting the main menu item:
Reproduces the problem

Control+C:
Reproduces the problem
Even if you press Control+C various times in a row.

Using the context menu to copy:
Successfully copies text to the clipboard and the problem goes away moving forward
Even just right clicking fixes the problem.

Using the paste top level menu item works fine.

[adamcmacdonald]

+1 able to fully reproduce problems on OSX 10.11.4

[kenorb]

Same here on OS X 10.11.2 with Brave 0.9.4.

Basically CMD-C does nothing (even on this page), apart of copying URL. Pasting works fine, but it's just pasting the old thing.

[something99]

Same, OSX 10.11.4 and Brave 0.10.0.
I've encountered this issue for a second time in a week. Can't copy anything new on Brave, pastes the old thing, other browsers and Word are fine though. Last time restarting the browser solved it.

[bbondy]

More information on this.
When it happens the top level menu item doesn't work either for Copy.
But the menu and shortcut does work for Cut.

I suspect it's something relating to the menu itself or the role we use for it.

[bbondy]

This seems to be fixed in 0.10.2 with @diracdeltas 's change. Closing for now.

[joshbabier]

Still happening. MacOS 10.12.6

[bsclifton]

@joshbabier we should have a fix for this soon- we're tracking with #10563 if you wanted to follow along 😄