Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add automated tests for prev/next buttons on tabTest.js #11267

Closed
luixxiul opened this issue Oct 4, 2017 · 1 comment
Closed

Add automated tests for prev/next buttons on tabTest.js #11267

luixxiul opened this issue Oct 4, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 4, 2017

Description

Add automated tests to tabTest.js for prev/next buttons on the tabs bar.

this.props.onPreviousPage
? <span
className='prevTab fa fa-caret-left'
onClick={this.onPrevPage} />
: null

this.props.onNextPage
? <span
className='nextTab fa fa-caret-right'
onClick={this.onNextPage} />
: null

Steps to Reproduce

  1. Run npm run test -- --grep='tab tests'

Actual result:

It is not tested whether the prex/next buttons work properly.

Expected result:

The buttons should be tested that:

  • They can be clicked
  • Clicking them would switch tab pages
  • Changing the value on about:preferences#tabs would show/hide them
  • Closing the last tab on a tab page would open the existing tab page (blank tab page should not appear)
  • Tabs, tabs' title and favicon would be re-rendered

etc.

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

The span was replaced with browserButton locally. See: #11272

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 4, 2017

CC @cezaraugusto

@cezaraugusto cezaraugusto self-assigned this Oct 4, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants