Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert tabs bar with Aphrodite to remove tabs.less #11272

Closed
luixxiul opened this issue Oct 4, 2017 · 2 comments · Fixed by #11530
Closed

Convert tabs bar with Aphrodite to remove tabs.less #11272

luixxiul opened this issue Oct 4, 2017 · 2 comments · Fixed by #11530
Assignees
@luixxiul
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 4, 2017 •
edited
Loading

Test plan

#11530 (comment)

Description

Refactor tabs bar to remove tabs.less.

Additional Information

It would be appreciated if #10686 would be based on this task. CC @petemill
@luixxiul luixxiul self-assigned this Oct 4, 2017
@luixxiul luixxiul mentioned this issue Oct 6, 2017
Closed
@luixxiul luixxiul mentioned this issue Oct 14, 2017
Merged
8 tasks
@luixxiul luixxiul changed the title Remove tabs.less Convert tabs bar with Aphrodite to remove tabs.less Oct 18, 2017
@cezaraugusto cezaraugusto mentioned this issue Oct 23, 2017
Closed
5 tasks
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Nov 7, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Convert tabs bar with Aphrodite
0599d7e 
Closes brave#11272

- Remove tabs.less
- Set color properties on theme.js
- Ser default properties on tabIcon.js
- BrowserButton component is applied to back/forward button and menu button on the tabs bar

Also:
- Apply no-drag to the new tab button and tab area
- Make the default icon large
- Add will-change:opacity to the animations
- Remove 'content' from theme.tab on theme.js

Test Plan:
1. Test that tabs are pinnable
2. Test that tabs are unpinnable
3. Test that tabs are draggable to same tabset
4. Test that tabs are draggable to alternate tabset
5. Test that tabs can be teared off into a new window
6. Test that you are able to reattach a tab that is teared off into a new window
7. Test that tab pages can be closed
8. Test that tab pages can be muted

Test Plan:
1. Test that the area around tab page indicators is draggable
2. Test that the gap between them is draggable
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@petemill petemill modified the milestones: 0.23.x (Developer Channel), 0.22.x (Beta Channel) Mar 19, 2018
@petemill
Copy link
Member

Moved to milestone 0.22.x due to requiring it for a clean merge of #12565 and the same / similar test plan for that version.

This was referenced Mar 22, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Convert tabs bar with Aphrodite
6 participants
@petemill @bbondy @luixxiul @srirambv @LaurenWags @btlechowski