Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab 'appear' animations run again when tab is moved #11470

Closed
petemill opened this issue Oct 12, 2017 · 2 comments · Fixed by #11501
Closed

Tab 'appear' animations run again when tab is moved #11470

petemill opened this issue Oct 12, 2017 · 2 comments · Fixed by #11501

Comments

@petemill
Copy link
Member

petemill commented Oct 12, 2017

Test plan

#11501 (comment)


Description

Tab 'appear' animations run again when tab element is moved via a new sort order.

59deb7b94d9cd406032710

Steps to Reproduce

  1. Create multiple tabs
  2. Observe that the tab icon fades in with animation
  3. Change tab order

Actual result:

  • Observe that tabs that are moved have their icons fade in with animation again

Expected result:

  • no fade-in animation

Reproduces how often: always

Brave Version

master, introduced in 33c5d10 for issue #10883 and PR

Test Plan

From PR #10691 / issue #10883 (create smooth transitions for tab components)

  • close icon, favicon, private, new session icons will have a smooth transition when enabled
  • audio icon will slightly scroll to the right when enabled

Resolving this issue

  • Create multiple tabs with favicons
  • Have a tab with audio playing and audio icon shown
  • Move the tabs around, there should be no flicker off / fade-in of favicon or audio icon
  • Repeat with tabs showing private icon, and session icon
@petemill petemill self-assigned this Oct 12, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 13, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 13, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 13, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 13, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 16, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 16, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 16, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Oct 25, 2017
cezaraugusto pushed a commit that referenced this issue Oct 27, 2017
Fix #11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 9, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fix brave#11470
Note that if we want to animate the unmounting of the component (when audio is stopped), then we should use https://github.com/reactjs/react-transition-group
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@petemill petemill modified the milestones: 0.23.x (Developer Channel), 0.22.x (Beta Channel) Mar 19, 2018
@petemill
Copy link
Member Author

Moved to milestone 0.22.x due to requiring it for a clean merge of #12565 and the same / similar test plan for that version.

@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.