Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tracking: Improve webpack build time/size #11476

Closed
cezaraugusto opened this issue Oct 12, 2017 · 4 comments
Closed

Tracking: Improve webpack build time/size #11476

cezaraugusto opened this issue Oct 12, 2017 · 4 comments

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Oct 12, 2017

@cezaraugusto cezaraugusto self-assigned this Oct 12, 2017
@cezaraugusto cezaraugusto changed the title Tracking: Improve webpack build time Tracking: Improve webpack build time/size Oct 12, 2017
@petemill
Copy link
Member

For the images, would it be more ideal to compress in source code since there wouldn't be any reason to have higher quality inside git, and then compress at compile-time on every build? I've often found that images used for different purposes have different compression vs quality concerns, and each use in a PR could be evaluated from a design point of view. For SVGs, when adding a new one, I always use https://jakearchibald.github.io/svgomg/

@cezaraugusto
Copy link
Contributor Author

that's nice, please jump in here or make a new issue/PR to track image optimization!

Plus, we make use of few FA icons and likely not use new ones in the near future so it would be nice to extract only the FA SVGs we use and put them in the tool you mentioned, or just run standalone imagemin for all images and push the optimized versions. What do you think about that?

@luixxiul luixxiul added the perf label Oct 16, 2017
@luixxiul
Copy link
Contributor

FYI: there is another tool https://github.com/svg/svgo

@petemill
Copy link
Member

petemill commented Oct 16, 2017

@luixxiul 👌 - the tool I linked to is just a manual GUI for SVGO. It would be interesting to try a pass on all existing SVGs with that, and then put a policy in place for future assets. We would have to test the output for quality and any over-optimization, especially if we're using CSS to style SVG elements that may have been stripped out 🖌

@NejcZdovc NejcZdovc removed the Epic label Nov 7, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
ayumi added a commit that referenced this issue Nov 29, 2017
@ayumi ayumi mentioned this issue Nov 29, 2017
8 tasks
bsclifton pushed a commit that referenced this issue Dec 4, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton added the stale label Aug 7, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants