Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Download bar cannot be closed with an active download #11923

Closed
srirambv opened this issue Nov 13, 2017 · 5 comments
Closed

Download bar cannot be closed with an active download #11923

srirambv opened this issue Nov 13, 2017 · 5 comments
Labels
0.19.x issue first seen in 0.19.x bug feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 13, 2017 •
edited by bsclifton
Loading

Test plan

See #13040

Description

Download bar cannot be closed with an active download

Steps to Reproduce

  1. Install/upgrade to 0.19.88
  2. Download a huge file
  3. Close the download bar while the download is active
  4. Download bar closes and becomes active again

Actual result:
Download bar cannot be closed with an active download

Expected result:
Should close the download bar even if there is an active download

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.88
rev c29eca6
Muon 4.5.15
libchromiumcontent 62.0.3202.89
V8 6.2.414.40
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.15063
OS Architecture x64

Reproducible on current live release:
Yes

Additional Information

cc: @LaurenWags to verify on mac
@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 13, 2017
@LaurenWags
Copy link
Member

Reproduced on MacOS. Removed Win label.

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
This was referenced Feb 5, 2018
Closed
Merged
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.23.x (Nightly Channel) Feb 7, 2018
@bsclifton bsclifton mentioned this issue Feb 21, 2018
Closed
@bsclifton
Copy link
Member

+1 from @eljuno via #13232

This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

Blocked on #14398

This was referenced Jun 21, 2018
Closed
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
This was referenced Jun 25, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 25, 2018 •
edited
Loading

No longer blocked as fix for #14398 is in 0.23.17.

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 25, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64 using

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.17 bc754eb
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.19.x issue first seen in 0.19.x bug feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@luixxiul @bsclifton @srirambv @LaurenWags @btlechowski