Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Download bar can now be closed when download is in progress #13040

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Download bar can now be closed when download is in progress #13040

merged 1 commit into from
Feb 8, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Feb 6, 2018

Fixes : #11923

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Launch Browser
  2. Open https://download.fedoraproject.org/pub/fedora/linux/releases/27/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-27-1.6.iso
  3. Choose save location as desktop
  4. Verify download bar shows
  5. Close download bar
  6. Verify download bar does not re-open

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@jasonrsadler
Copy link
Contributor Author

Try to add label PR/needs-QA-attention
Don't see where to add

@bsclifton bsclifton changed the title Fixes Issue 11923 Download bar can now be closed when download is in progress Feb 7, 2018
@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 7, 2018
@bsclifton bsclifton self-requested a review February 7, 2018 20:59
@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #13040 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13040      +/-   ##
==========================================
- Coverage   56.25%   56.21%   -0.05%     
==========================================
  Files         280      280              
  Lines       27517    27520       +3     
  Branches     4486     4486              
==========================================
- Hits        15480    15470      -10     
- Misses      12037    12050      +13
Flag Coverage Δ
#unittest 56.21% <0%> (-0.05%) ⬇️
Impacted Files Coverage Δ
app/filtering.js 17.92% <0%> (-0.12%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 84.61% <0%> (-6.16%) ⬇️
js/stores/windowStore.js 27.69% <0%> (-0.3%) ⬇️
...erer/components/preferences/payment/ledgerTable.js 87.75% <0%> (-0.07%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works great! I rebased and squashed your commits (code is still the same). Great job on this 😄 👍

@bsclifton bsclifton merged commit 740dae2 into brave:master Feb 8, 2018
@jasonrsadler
Copy link
Contributor Author

jasonrsadler commented Feb 8, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants