Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fonts not loading correctly on master #12280

Closed
petemill opened this issue Dec 14, 2017 · 1 comment
Closed

Fonts not loading correctly on master #12280

petemill opened this issue Dec 14, 2017 · 1 comment
Assignees
@petemill
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@petemill
Copy link
Member

petemill commented Dec 14, 2017 •
edited
Loading

There are problems with the rules introduced in #12225 - font files are matching multiple rules causing the browser to not be able to parse and display the fonts.

Steps to Reproduce

Open new tab page

Actual result:
Fonts are system fonts.
Console has many errors related to fonts.

image

Expected result:
Fonts used are Poppins / Muli.
Console has no errors.

image

Reproduces how often:
100%

Brave Version

about:brave info:
master

Reproducible on current live release:
No
@petemill petemill self-assigned this Dec 14, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Dec 14, 2017
@petemill
webpack - fix fonts matching multiple webpack rules
bf89bf0 
Fixes fonts and icons not loading correctly due to new rules introduced in brave#12225
Fix brave#12280
@petemill petemill mentioned this issue Dec 14, 2017
Merged
8 tasks
petemill added a commit to petemill/browser-laptop that referenced this issue Dec 14, 2017
@petemill
webpack - fix fonts matching multiple webpack rules
bfaea8c 
Fixes fonts and icons not loading correctly due to new rules introduced in brave#12225
Fix brave#12280
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Dec 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 19, 2018 •
edited by btlechowski
Loading

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @bbondy @kjozwiak @luixxiul @srirambv @btlechowski