Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

PDF not loaded when browser is relaunched #12483

Closed
srirambv opened this issue Jan 3, 2018 · 3 comments
Closed

PDF not loaded when browser is relaunched #12483

srirambv opened this issue Jan 3, 2018 · 3 comments
Assignees
Labels
bug plugin/pdfjs priority/P4 Minor loss of function. Workaround usually present. regression wontfix

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 3, 2018

Description

PDF not loaded when browser is relaunched

Steps to Reproduce

  1. Open a PDF file in a new tab
  2. Close the browser and reopen it, pdf shows as file not found
  3. Reload the tab, PDF loads again

Actual result:
PDF not loaded when browser is relaunched

Expected result:
Should load the PDF when browser restarts

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.14
V8 6.3.292.48
rev 5d75826
Muon 4.5.33
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 63.0.3239.108

Reproducible on current live release:
No

Additional Information

Reproduces on all platfrom
#12408

@srirambv srirambv added 0.20.x issue first seen in 0.20.x bug plugin/pdfjs regression labels Jan 3, 2018
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@bsclifton
Copy link
Member

@diracdeltas have you gotten a chance to check this one out? I'm wondering if we should move it to 0.21.x

@diracdeltas
Copy link
Member

@bsclifton i think it can be moved, though i'll try to get to it after doing security issues

@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Jan 9, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Jan 9, 2018
@alexwykoff alexwykoff removed the 0.20.x issue first seen in 0.20.x label Jan 9, 2018
@alexwykoff alexwykoff modified the milestones: 0.21.x (Beta Channel), Backlog (Prioritized) Feb 20, 2018
@petemill
Copy link
Member

This also happens when you navigate back from a PDF and then forward again, or when a tab is discarded (to release memory) and then loaded again.

More detail on what's causing this:
For some reason, after the page is rendered, muon is changing its stored url from:
chrome-extension://jdbefljfgobbmcidnmpjamcbhnbphjnb/content/web/viewer.html?file=http%3A%2F%2Fwww.pdf995.com%2Fsamples%2Fpdf.pdf
to:
chrome-extension://jdbefljfgobbmcidnmpjamcbhnbphjnb/http://www.pdf995.com/samples/pdf.pdf, hence 404

@bridiver mentions that there is now setURLHandler and setReverseURLHandler in the browser-side extension api to replace all the url handlers we have in browser-laptop, but that this should be able to be fixed in browser-laptop.

@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Sep 18, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug plugin/pdfjs priority/P4 Minor loss of function. Workaround usually present. regression wontfix
Projects
None yet
Development

No branches or pull requests

5 participants