Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reload tab doesn't load PDF #12408

Closed
srirambv opened this issue Dec 27, 2017 · 4 comments · Fixed by #12431
Closed

Reload tab doesn't load PDF #12408

srirambv opened this issue Dec 27, 2017 · 4 comments · Fixed by #12431
Assignees
@diracdeltas
Labels
0.20.x issue first seen in 0.20.x bug plugin/pdfjs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 27, 2017 •
edited by luixxiul
Loading

Test plan

#12431 (comment)

Description

Reload tab doesn't load PDF after quit-restart

Steps to Reproduce

  1. Clean install 0.20.11
  2. Visit https://basicattentiontoken.org/ and click on the Whitepaper to load the pdf in a new tab
  3. Quit/Close and reopen browser, Shows pdf is not loaded
  4. Press the reload button, pdf still doesn't load
  5. Highlight URL and press Enter, pdf is loaded
  6. Type in http://orimi.com/pdf-test.pdf/ in a new tab and repeat steps 3-5, same result

Actual result:
pdf

Expected result:
PDF should load when the browser is restarted

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.11
V8 6.3.292.48
rev 9bb3c67
Muon 4.5.31
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 63.0.3239.108

Reproducible on current live release:
Partially, After restart, PDF tab shows file not found, Reload the tab loads the pdf.
pdf-019

Additional Information

cc: @petemill @diracdeltas @NejcZdovc
Could be related to the recent reload fix
@srirambv srirambv added 0.20.x issue first seen in 0.20.x bug plugin/pdfjs labels Dec 27, 2017
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Dec 27, 2017
@srirambv srirambv changed the title Reload tab doesn't load PDF after quite-restart Reload tab doesn't load PDF after quit-restart Dec 27, 2017
@diracdeltas diracdeltas self-assigned this Dec 28, 2017
@diracdeltas
Copy link
Member

it's also broken on master (didn't try 0.20.x yet) if you simply reload any PDF. it shows file not found. fix incoming.

diracdeltas added a commit that referenced this issue Dec 28, 2017
@diracdeltas
Fix PDF reloading
eb8d253 
fix #12408

Test plan:
1. load any PDF
2. hit reload
3. it should reload the PDF instead of 'file not found'
@diracdeltas diracdeltas mentioned this issue Dec 28, 2017
Merged
10 tasks
This was referenced Jan 2, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Jan 3, 2018

Issue still happens when you quit the browser and relaunch. Reloading the tab loads the pdf. Same behaviour on all platforms.

@srirambv srirambv reopened this Jan 3, 2018
@diracdeltas
Copy link
Member

@srirambv i thought this issue was for reloading the tab not loading the PDF. please open a separate issue for PDF not loading after restart.

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 3, 2018

Will do

@srirambv srirambv closed this as completed Jan 3, 2018
@srirambv srirambv mentioned this issue Jan 3, 2018
Closed
This was referenced Jan 9, 2018
Closed
Closed
@srirambv srirambv changed the title Reload tab doesn't load PDF after quit-restart Reload tab doesn't load PDF Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
0.20.x issue first seen in 0.20.x bug plugin/pdfjs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix PDF reloading brave/browser-laptop
4 participants
@diracdeltas @bsclifton @srirambv @LaurenWags