Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Empty Ad Containers on Yahoo! #12918

Closed
jonathansampson opened this issue Jan 30, 2018 · 7 comments · Fixed by #12964 or #14638
Closed

Empty Ad Containers on Yahoo! #12918

jonathansampson opened this issue Jan 30, 2018 · 7 comments · Fixed by #12964 or #14638

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jan 30, 2018

Test plan

See #12964

Description

Brave is successfully blocking ads and trackers, but isn't removing empty ad containers. The following screenshot was procured from @spencernoon's tweet:
image

Steps to Reproduce

  1. Navigate to https://yahoo.com

Actual result:
Empty ad containers are visible

Expected result:
Empty ad containers should be hidden

Reproduces how often:
Always

Brave Version

0.19.147

Reproducible on current live release:
Yes

Additional Information

There are additional ad containers as you browse the Yahoo! site.

Related to #8057

@MargarytaChepiga
Copy link
Contributor

I would love to give it a try to fix! Can I work on it?

@sepeiFH
Copy link

sepeiFH commented Jan 30, 2018

adding #my-adsLDRB to the list in browser-laptop/app/extensions/brave/content/styles/removeEmptyElements.css should fix the problem

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018

@bsclifton Issue still persists on 0.23.8
12918

@bsclifton
Copy link
Member

The selector might have changed- did you want to check this out, @jonathansampson?

@bsclifton
Copy link
Member

Moving out of milestone; if we get a fix we can pull back in

@I3uckwheat
Copy link

I would like to work on this :)

@ryanml ryanml assigned ryanml and unassigned jonathansampson Jul 3, 2018
@ryanml
Copy link
Contributor

ryanml commented Jul 3, 2018

@I3uckwheat awesome :D Thanks for taking it on.

I've self-assigned this issue so no one else will take it :) Feel free to let myself or another team member know if you have any questions. 🎊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.