Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sites are not added to the ledger table #13410

Closed
NejcZdovc opened this issue Mar 9, 2018 · 1 comment
Closed

Sites are not added to the ledger table #13410

NejcZdovc opened this issue Mar 9, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 9, 2018 •
edited by bsclifton
Loading

Description

This was broken with #13236

Test plan / Steps to Reproduce

  1. Enable payments
  2. Visit a site

Actual result:

Site is not added to the table

Expected result:

Reproduces how often:

Site should be added to the table

Brave Version

about:brave info:

0.23 up

Reproducible on current live release:

Additional Information
@NejcZdovc NejcZdovc added this to the 0.23.x (Nightly Channel) milestone Mar 9, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 9, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 9, 2018
@NejcZdovc
Fixes location validation
8abc526 
Resolves brave#13410

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Mar 9, 2018
Merged
10 tasks
NejcZdovc added a commit that referenced this issue Mar 11, 2018
@NejcZdovc
Merge pull request #13411 from NejcZdovc/hotfix/#13410-tldjs
9d5977a 
Fixes location validation
NejcZdovc added a commit that referenced this issue Mar 11, 2018
@NejcZdovc
Merge pull request #13411 from NejcZdovc/hotfix/#13410-tldjs
217baa5 
Fixes location validation
This was referenced Jun 11, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64
• 0.23.8 06c657b
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 19, 2018
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@bsclifton @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya