Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Right click on any setup file and open in new tab doesn't download the file #14409

Closed
GeetaSarvadnya opened this issue Jun 14, 2018 · 7 comments
Closed

Right click on any setup file and open in new tab doesn't download the file #14409

GeetaSarvadnya opened this issue Jun 14, 2018 · 7 comments
Assignees
@bridiver @bsclifton
Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch feature/download priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 5 ...

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018 •
edited by bsclifton
Loading

Description

Right click on any setup file and open in new tab doesn't download the file

Test plan / Steps to Reproduce

  1. Open brave with clean profile
  2. Open https://github.com/brave/browser-laptop/releases
  3. Right click on any setup file->Open in new tab

Actual result:
Right click on any setup file and open in new tab doesn't download the file>
open in new tab reloads the same tab

Expected result:
Right click on any setup file and open in new tab should download the file

Reproduces how often:
Easy

Brave Version

0.23.8
about:brave info:

Brave: 0.23.8
V8: 6.6.346.32
rev: 06c657b
Muon: 6.1.5
OS Release: 10.0.17134
Update Channel: Beta
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.181

Reproducible on current live release:
Yes

Additional Information
@GeetaSarvadnya GeetaSarvadnya added this to the 0.23.x (Beta Channel) milestone Jun 14, 2018
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Jun 19, 2018
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jun 19, 2018
@bsclifton bsclifton added 0.22.x issue first seen in 0.22.x and removed regression labels Jun 20, 2018
@bsclifton
Copy link
Member

bsclifton commented Jun 20, 2018 •
edited
Loading

This happens on our current release. Perhaps this regressed with single webview?

@darkdh
Copy link
Member

darkdh commented Jun 20, 2018

And we need to test if it is reproducible in pre-single-webview release
The current behavior is download dialog does got opened but tab will be closed. You can observe that by doing "Open Link in New Window"

@bsclifton
Copy link
Member

Moving to next release. Finding a fix would be great, but this has been present for at least 1 release

@LaurenWags LaurenWags mentioned this issue Jul 25, 2018
Closed
@bsclifton
Copy link
Member

Lots of good debugging done on this one in #14844

Basically, the new tab is created with the download item... but the tab doesn't attach the webview in time. The code tries to lookup what window it's associated with and there is no info, because nothing is attached. So it exits

@bsclifton bsclifton self-assigned this Jul 28, 2018
@bsclifton bsclifton added 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch and removed 0.22.x issue first seen in 0.22.x regression-range-wanted labels Jul 28, 2018
@bsclifton
Copy link
Member

Confirmed this was introduced with 0.22.714 (our initial single webview build)

bsclifton added a commit to brave/muon that referenced this issue Jul 30, 2018
@bsclifton
Get native window reference manually if it's not found in user data (…
4504af1 
…as a result of losing a race condition)

Fixes brave/browser-laptop#14409

Auditors: @bridiver
@bsclifton
Copy link
Member

Fixed with brave/muon@4504af1

This will be part of 0.23.x Release 5 (builds not available yet)

@bsclifton bsclifton added release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Jul 30, 2018
darkdh pushed a commit to brave/muon that referenced this issue Jul 31, 2018
@bsclifton @darkdh
Get native window reference manually if it's not found in user data (…
6295f8f 
…as a result of losing a race condition)

Fixes brave/browser-laptop#14409

Auditors: @bridiver
darkdh pushed a commit to brave/muon that referenced this issue Aug 3, 2018
@bsclifton @darkdh
Get native window reference manually if it's not found in user data (…
a2f7fb4 
…as a result of losing a race condition)

Fixes brave/browser-laptop#14409

Auditors: @bridiver
This was referenced Aug 14, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Aug 14, 2018 •
edited by kjozwiak
Loading

Verified on Ubuntu 18 x64 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84
  • Verified the download completes when opening a setup link in a new tab

Verified with macOS 10.12.6 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Windows x64 with

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

@bsclifton bsclifton

Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch feature/download priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

No branches or pull requests
8 participants
@bridiver @petemill @alexwykoff @bsclifton @darkdh @srirambv @LaurenWags @GeetaSarvadnya