Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update contribution auto-include to use recently updated server provided list #14498

Closed
evq opened this issue Jun 21, 2018 · 2 comments
Closed

Update contribution auto-include to use recently updated server provided list #14498

evq opened this issue Jun 21, 2018 · 2 comments
Assignees
@ryanml
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x Release 4 ...

Comments

@evq
Copy link
Member

evq commented Jun 21, 2018 •
edited by kjozwiak
Loading

Test Plan

Description

Currently we use the ruleset db for controlling automatic inclusion for contributions on a per publisher basis. We should instead use the exclude property of the identity api, see below for an example of the response:

curl https://ledger-staging.mercury.basicattentiontoken.org/v3/publisher/identity\?publisher\=amazon.com
{"publisher":"amazon.com","SLD":"amazon.com","RLD":"","QLD":"","URL":"amazon.com","properties":{"exclude":true}}%
@NejcZdovc NejcZdovc added this to the 0.24.x (Developer Channel) milestone Jun 26, 2018
@evq evq changed the title Contribution auto-include should use identity API exclude property Update contribution auto-include to use recently updated server provided list Jun 27, 2018
@ryanml ryanml self-assigned this Jul 14, 2018
This was referenced Jul 17, 2018
Merged
Closed
Merged
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 17, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
a42a543 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 18, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
301ad47 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 19, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
0f5dec9 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 19, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
92833ae 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 21, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
a77fea6 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 24, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
b7d7dbf 
…ves ruleset code
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 24, 2018
@ryanml
Fixes brave#14498, uses publisher-data.json for exclusion props, remo…
3ee3462 
…ves ruleset code
@LaurenWags
Copy link
Member

@ryanml @evq could we get a test plan for this one?

This was referenced Jul 27, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jul 27, 2018 •
edited by btlechowski
Loading

Verified with macOS 10.12.6 using

  • 0.23.73 50bdb6d
  • Muon 8.0.3
  • libchromiumcontent 68.0.3440.75
    screen shot 2018-07-27 at 5 24 58 pm

Verified on Windows x64 with
• 0.23.73 50bdb6d
• Muon 8.0.3
• libchromiumcontent 68.0.3440.75

Verified on Ubuntu 17.10 x64

  • 0.23.73 50bdb6d
  • Muon 8.0.3
  • libchromiumcontent 68.0.3440.75

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x Release 4 w/ Chromium 68 (Rele...
Development

No branches or pull requests
8 participants
@alexwykoff @kjozwiak @ryanml @evq @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya