Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove PIA #14763

Closed
diracdeltas opened this issue Jul 17, 2018 · 5 comments
Closed

remove PIA #14763

diracdeltas opened this issue Jul 17, 2018 · 5 comments
Assignees
@NejcZdovc
Labels
privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude security
Milestone
0.23.x Release 4 ...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jul 17, 2018 •
edited by srirambv
Loading

Test plan

See #14774

we decided to not use PIA anymore

are there infrastructure changes needed for this or is it just a matter of changing the endpoints in browser-laptop? @evq @mrose17

related: #12923
@diracdeltas diracdeltas added this to the 0.23.x Release 4 milestone Jul 17, 2018
@alexwykoff
Copy link
Contributor

We'd like to make sure this goes with C68

@evq
Copy link
Member

evq commented Jul 17, 2018

no infra changes, just a matter of removing this logic -

browser-laptop/app/browser/api/ledger.js

Line 1597 in d603250

parts.hostname = 'mercury-proxy.privateinternetaccess.com'

@diracdeltas
Copy link
Member Author

@alexwykoff so move the milestone to 0.23 with c68?

@diracdeltas
Copy link
Member Author

nvm i understand

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 18, 2018
@NejcZdovc
Removes PIA
589a62e 
Resolves brave#14763

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jul 18, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 18, 2018
@NejcZdovc
Removes PIA
469e636 
Resolves brave#14763

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 18, 2018
@NejcZdovc
Removes PIA
e9f6f29 
Resolves brave#14763

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 18, 2018
@NejcZdovc
Merge pull request #14774 from NejcZdovc/fix/#14763-pia
c07fe93 
Removes PIA
NejcZdovc added a commit that referenced this issue Jul 18, 2018
@NejcZdovc
Merge pull request #14774 from NejcZdovc/fix/#14763-pia
3258025 
Removes PIA
NejcZdovc added a commit that referenced this issue Jul 18, 2018
@NejcZdovc
Merge pull request #14774 from NejcZdovc/fix/#14763-pia
a38be75 
Removes PIA
This was referenced Jul 21, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jul 23, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64 using

  • 0.23.70 e63c780
  • Muon 8.0.1
  • libchromiumcontent 68.0.3440.68

Verified on Ubuntu 17.10 x64

  • 0.23.70 e63c780
  • Muon 8.0.1
  • libchromiumcontent 68.0.3440.68

Verified with macOS 10.12.6 using

  • 0.23.70 e63c780
  • Muon 8.0.1
  • libchromiumcontent 68.0.3440.68

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude security
Projects
None yet
Milestone
0.23.x Release 4 w/ Chromium 68 (Rele...
Development

No branches or pull requests
8 participants
@diracdeltas @alexwykoff @kjozwiak @evq @NejcZdovc @srirambv @LaurenWags @btlechowski