Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Advertise Brotli compression #2890

Closed
ericlaw1979 opened this issue Aug 2, 2016 · 5 comments
Closed

Advertise Brotli compression #2890

ericlaw1979 opened this issue Aug 2, 2016 · 5 comments
Milestone

Comments

@ericlaw1979
Copy link

Brave should advertise its support for Brotli compression (like Firefox and Chrome) for significantly better text compression than gzip/deflate. https://textslashplain.com/2015/09/10/brotli/

Visit, e.g. https://bayden.com/ua.aspx

Observe: Accept-Encoding header does not contain br. Notably, the star images at the bottom of the page render, which indicates that Brave is successfully decompressing brotli-encoded content, it's just not advertising its support.

Windows 7.
Brave: 0.11.1
Electron: 1.2.7
libchromiumcontent: 51.0.2704.103
V8: 5.1.281.65
Node.js: 6.1.0
Update Channel: dev

@diracdeltas
Copy link
Member

++, this would also help with #2229

diracdeltas added a commit to brave/muon that referenced this issue Aug 2, 2016
This is needed for brave/browser-laptop#2890.
Maybe it should just be on by default instead of as a session method.

Auditors: @bbondy
@diracdeltas
Copy link
Member

brotli compression is actually not on right now as far as i can tell - hence the stars show up as orange instead of green

but brave/muon#32 turns it on over HTTPS and advertises it in the header too

@ericlaw1979
Copy link
Author

The stars show in orange when Accept-Encoding does not include "br". They show in green when "br" is included. They fail to render entirely when brotli is not supported (as they're served with brotli compression

@ericlaw1979
Copy link
Author

unconditionally)

@diracdeltas
Copy link
Member

ah, thanks for the clarification

diracdeltas added a commit that referenced this issue Aug 2, 2016
@luixxiul luixxiul added this to the 0.11.4dev milestone Aug 9, 2016
bridiver pushed a commit to brave/muon that referenced this issue Aug 15, 2016
This is needed for brave/browser-laptop#2890.
Maybe it should just be on by default instead of as a session method.

Auditors: @bbondy
bridiver pushed a commit to brave/muon that referenced this issue Sep 17, 2016
This is needed for brave/browser-laptop#2890.
Maybe it should just be on by default instead of as a session method.

Auditors: @bbondy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants