Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Users can create bookmark folders with no name #3188

Closed
alexwykoff opened this issue Aug 15, 2016 · 0 comments
Closed

Users can create bookmark folders with no name #3188

alexwykoff opened this issue Aug 15, 2016 · 0 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
On the Bookmarks toolbar, if I choose to create a new folder, I do not have to provide a folder name. A folder with no name is created.

Expected behavior:
The system should prevent me from creating a folder with no name.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    Discovered in 0.11.5 RC1, but repro'd in 0.11.2. It's probably always been there.
  • Steps to reproduce:
    1. Make sure the bookmarks toolbar is visible
    2. Right-click on the toolbar and select 'Add Folder...'
    3. Click Save
  • Screenshot if needed:
    blank_bookmark_folder
  • Any related issues:
@bbondy bbondy closed this as completed in 2ac4180 Aug 17, 2016
bbondy added a commit that referenced this issue Aug 17, 2016
Validate bookmark name before creation Fixes #3188
@bbondy bbondy added this to the 0.11.6dev milestone Aug 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants