Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Closed frames shouldn't include newtab #3258

Closed
bbondy opened this issue Aug 19, 2016 · 2 comments · Fixed by #3804
Closed

Closed frames shouldn't include newtab #3258

bbondy opened this issue Aug 19, 2016 · 2 comments · Fixed by #3804
Assignees
@BrendanEich
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.1dev

Comments

@bbondy
Copy link
Member

bbondy commented Aug 19, 2016 •
edited
Loading

It's a bit strange to see new tab showing up in the closed tab menu button a lot. Maybe only navigatable isNavigatableAboutPage pages should be included when adding to closedFrames.

Steps to reproduce:

  1. Open a new tab
  2. Close the tab (which is still on the new tab page)
  1. Check the history menu, it shows Recently Closed as New tab

cc @bsclifton
@bsclifton
Copy link
Member

bsclifton commented Aug 22, 2016 •
edited by bbondy
Loading

It's worth noting this is distinctly different from #2856 (which gets the history from Chromium via Electron's NavigationController)

@bsclifton
Copy link
Member

This should be fixed- self assigning so I can review

@bsclifton bsclifton self-assigned this Aug 30, 2016
@bbondy bbondy added this to the 0.12.1dev milestone Sep 7, 2016
@BrendanEich BrendanEich self-assigned this Sep 8, 2016
BrendanEich added a commit that referenced this issue Sep 8, 2016
@BrendanEich
Closed frames shouldn't include newtab
56e9ecc 
Fix #3258

Auditors: @bbondy

Test Plan: New Tab, close it, look in History menu to ensure it's not among recently closed
@BrendanEich BrendanEich mentioned this issue Sep 8, 2016
Merged
This was referenced Sep 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 14, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrendanEich BrendanEich

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.1dev
Development

Successfully merging a pull request may close this issue.

Closed frames shouldn't include newtab brave/browser-laptop
6 participants
@BrendanEich @bbondy @alexwykoff @luixxiul @bsclifton @srirambv