Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill Modal doesn't show when about:autofill opened from about:about #4350

Closed
srirambv opened this issue Sep 28, 2016 · 1 comment · Fixed by #4357
Closed

Autofill Modal doesn't show when about:autofill opened from about:about #4350

srirambv opened this issue Sep 28, 2016 · 1 comment · Fixed by #4357
Assignees
@darkdh
Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression
Milestone
0.12.4dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Autofill Modal doesn't show when about:autofill opened from about:about

Expected behavior:
Should open autofill modal irrespective how about:autofill is opened

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.3dev-RC1 (Clean install)
  • Steps to reproduce:
    1. Open about:about page
    2. Click on about:autofill
    3. Click on add address doesn't show the autofill modal
  • Screenshot if needed:
    autofill1
  • Any related issues:
    cc: @darkdh
@srirambv srirambv mentioned this issue Sep 28, 2016
Closed
@luixxiul
Copy link
Contributor

Confirmed on Win10 32bit

darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 28, 2016
@darkdh
Defer setAutofill*Detail to frame.js
f1b50bc 
fix brave#4350

Auditors: @bbondy

Test Plan:
1. open about:autofill from about:about
2. add/edit entry should work fine
@darkdh darkdh mentioned this issue Sep 28, 2016
Merged
4 tasks
@bbondy bbondy added this to the 0.12.4dev milestone Oct 4, 2016
This was referenced Oct 4, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 5, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.4dev
Development

Successfully merging a pull request may close this issue.

Defer setAutofill*Detail to frame.js darkdh/browser-laptop
6 participants
@aekeus @bbondy @alexwykoff @luixxiul @darkdh @srirambv