Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make bookmark and history management look nicer #441

Closed
ghost opened this issue Jan 29, 2016 · 10 comments · Fixed by #3320
Closed

Make bookmark and history management look nicer #441

ghost opened this issue Jan 29, 2016 · 10 comments · Fixed by #3320
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@ghost
Copy link

ghost commented Jan 29, 2016

As Chromium has truly ugly bookmark management and history, i would appreciate it if you would make both parts look more nicer and add more functionality so that it is not that bare bone style.

@luixxiul luixxiul changed the title Usability suggestions Make bookmark and history management nicer May 15, 2016
@luixxiul luixxiul changed the title Make bookmark and history management nicer Make bookmark and history management look nicer May 15, 2016
@luixxiul
Copy link
Contributor

Being worked on. The detail is on the issue, whose number I cannot remember. Maybe @bradleyrichter could.

@ghost
Copy link
Author

ghost commented May 15, 2016

Good to see that some of my suggestions are considered as useful :D As power user i care of course for tons of customization features and a bit for design too :D

@bsclifton bsclifton self-assigned this Aug 19, 2016
@bsclifton bsclifton added the design A design change, especially one which needs input from the design team. label Aug 19, 2016
@bsclifton
Copy link
Member

Happy to report that this issue is being worked on right now 😄

Here's what's currently in master- a bare bones history screen:
screen shot 2016-08-18 at 11 06 26 pm

You can right click to delete entries or open them in a new tab. You can also double click entries to open them.

I'm currently adding search and then I'm also trying to organize the entries by date (along with some style updates). Suggestions or mockups are extremely welcome 😄

@bsclifton
Copy link
Member

bsclifton commented Aug 19, 2016

and here's where we're at now:
screen shot 2016-08-19 at 1 45 28 am

@bradleyrichter (and anyone reading this too) let me know what you think 😄

I grabbed styles from Preferences because I wanted it to look "Brave-esque", rather than the mild black text on white background. I put some sample buttons there similar to Chrome, wiring them up wouldn't be too hard (including checkboxes for deleting individual items). We could also put some options above the buttons

One thing not shown is search. I am going to implement a search, similar to the bookmarks manager page. This would be on the same line as the "History" title.

@srirambv
Copy link
Collaborator

srirambv commented Aug 19, 2016

@bsclifton Looks really good. Making urls align in a column would make it look even more polished like a tabular items something similar to this (personal preference)

image

@bbondy
Copy link
Member

bbondy commented Aug 20, 2016

The grouping should be pretty easily accomplished by using something like:
http://underscorejs.org/#groupBy

I think ledger introduced the dependency so you can use it. Or else just copy the impl and modify slightly.

@bsclifton
Copy link
Member

bsclifton commented Aug 20, 2016

@bbondy does underscore.js have advantages over Array.reduce? Here's a link to the code I put together, it's fairly clean:
https://github.com/bsclifton/browser-laptop/blob/history-page/js/about/history.js#L88

@bbondy
Copy link
Member

bbondy commented Aug 20, 2016

ah sorry I didn't realize you had it done already, your way is fine.

@bsclifton bsclifton mentioned this issue Aug 20, 2016
3 tasks
@bsclifton
Copy link
Member

Here's a screencap of the proposed look, courtesy of @bradleyrichter! Going to start molding the screen to look more like this...
image

@bsclifton
Copy link
Member

bsclifton commented Aug 21, 2016

Starting to get there... here's where I'm at currently:
screen shot 2016-08-21 at 12 23 32 pm

NOTE: context menu is broken at the moment; will have to add generic functionality for that to sortableTable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants