Updates to history page #3281
Updates to history page #3281
Conversation
|
Now for some screenshots 😄 Please review and give me feedback; I can update the styles and take care of any asks you may have. Here's a shot of the regular screen: When you click You can search the results; one thing to note, it shows the time next to each entry, but does NOT group it by day. I need to fix this and would like to hear recommendations about how to show results. For sure, we'd want to say "X results found" (which is not currently shown) Highlight color is no longer BLUE (like the bookmarks page). Instead, it borrows from SortableTable (see preferences > search for an example). Context menu works great. Anything else we'd like to see here? |
|
Still working through some look and feel updates per the proposed mockup from @bradleyrichter: This PR is fairly close to that look and feel right now. The content for each day is now stored in SortableTable control. This control is also used for the default search engines in preferences, so we need to confirm that still works as expected. Here's a live shot: My next step: look into creating tests for this new functionality. The remaining work before it matches 100% (which can be broken out to separate issues):
|
|
Ready for re-review 😄 |
|
Of course, styles can be refined. I'll poke around a bit. But looking good so far! The one question I have for now is if we can live with only one column header at the top? This would become the "sort captain" and all sub-tables would follow. This should cut down the redundancy and still provide the intended function. |
- Style refresh (fairly close to mockup) - changed color of about:history tab - Page now breaks history items down by date (sorted desc) - shortened location shown to "domain.tld" - page is now localized (including formatting dates) - added working "Clear browsing data button" - history is now searchable (also broken down by date) - updated page to use SortableTable Fixes #441 Updates to SortableTable control: - renamed hoverCallback and isHover, giving a more clear name - extended to allow optional classnames per column - can process onClick, onDoubleClick, and onContextMenu - new `rowObjects` property, useful for mapping a row to the raw object
|
@bradleyrichter a single table header... that's an interesting idea. It would take some extra work, but I think it's feasible |
|
going to open off of a shared branch |
git rebase -ito squash commits if needed.There is a bare-bones history page in place. This PR updates the styles to make it look more "Brave-like" (borrowing from about:preferences), adds the ability to search history, and groups
history items by date. All strings are localized and ready for translation.
cc: @bradleyrichter @bbondy
Specific changes from commit log:
Fixes #441