Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill suggestion should close when form is submit / enter pressed #4540

Closed
bsclifton opened this issue Oct 5, 2016 · 1 comment · Fixed by #5287
Closed

Autofill suggestion should close when form is submit / enter pressed #4540

bsclifton opened this issue Oct 5, 2016 · 1 comment · Fixed by #5287
Assignees
@darkdh
Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When typing into input fields, autocomplete suggestions do not automatically close when you press enter

Expected behavior:
Suggestion should close when I push enter / submit the form

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS
  • Brave Version:
    0.12.3
  • Steps to reproduce:
    1. Go to https://github.com/brave/browser-laptop/issues
    2. In the filters textbox, start typing characters until autocomplete pops up
    3. Push enter to submit
    4. Notice autocomplete suggestion is still on screen
  • Screenshot if needed:
  • Any related issues:
@bsclifton bsclifton changed the title Autocomplete suggestion should close when form is submit / enter pressed Autofill suggestion should close when form is submit / enter pressed Oct 29, 2016
@bsclifton
Copy link
Member Author

related: #3816

This should also close after 1Password or other extensions fill out the form (ex: when pushing Ctrl + \ or Cmd + )

@bsclifton bsclifton mentioned this issue Oct 29, 2016
Closed
@darkdh darkdh added this to the 1.0.0 milestone Oct 31, 2016
@darkdh darkdh self-assigned this Oct 31, 2016
@darkdh darkdh modified the milestones: 0.12.9dev, 1.0.0 Oct 31, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 31, 2016
@darkdh
Implement hide-autofill-popup
68d8db6 
fix brave#3816
fix brave#4540
fix brave#5023

Auditors: @bbondy

Test Plan:
1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Scroll the page should dismiss the popup

1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Popup should be dismissed
@darkdh darkdh mentioned this issue Oct 31, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Implement hide-autofill-popup darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv