Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some Yahoo ads not being blocked on yahoo.co.jp #4762

Closed
bbondy opened this issue Oct 14, 2016 · 3 comments
Closed

Some Yahoo ads not being blocked on yahoo.co.jp #4762

bbondy opened this issue Oct 14, 2016 · 3 comments
Assignees
@luixxiul
Labels
feature/adblock QA/checked-Win32 QA/checked-Win64
Milestone
0.12.5dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 14, 2016

The watch, bag, ....
screenshot 2016-10-13 20 51 07
@bbondy bbondy added this to the 0.12.5dev milestone Oct 14, 2016
@bbondy
Copy link
Member Author

bbondy commented Oct 14, 2016

Fixed, cc @luixxiul for testing
screenshot 2016-10-13 20 55 33

This was referenced Oct 14, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Sweet! I will check it out soon :-D

@luixxiul luixxiul self-assigned this Oct 14, 2016
@luixxiul
Copy link
Contributor

Checked ;-)

This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
bbondy added a commit to brave-experiments/ad-block that referenced this issue Oct 25, 2016
@bbondy
Fix yahoo.co.jp not blocking all images
75a1753 
This is because we did lookups with separator chars inside the bloom filter and concluded it didn't exist

Fix brave/browser-laptop#4762
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/adblock QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.5dev
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @srirambv