Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import recovery keys feature #4806

Closed
luixxiul opened this issue Oct 15, 2016 · 9 comments
Closed

Import recovery keys feature #4806

luixxiul opened this issue Oct 15, 2016 · 9 comments
Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 15, 2016 •
edited by srirambv
Loading

Describe the issue you encountered: Now you can export your brave wallet recovery key, it would be great to have a feature of importing it on "Recover your wallet" modal window.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Steps to reproduce:
    1. Go to about:preferences#payments
    2. Click Advanced Settings
    3. Click "backup your wallet"
    4. Click "save recovery file"
    5. Click "done"
    6. Click "recover your wallet"
    7. A button named "import recovery keys" should exist next to the button "recover"
  • Any related issues:
@luixxiul luixxiul mentioned this issue Oct 15, 2016
Closed
@mrose17
Copy link
Member

mrose17 commented Oct 17, 2016

@luixxiul - i'm a bit confused, what action needs to be taken with respect to this issue?

@luixxiul
Copy link
Contributor Author

a button to import recovery key.

@mrose17
Copy link
Member

mrose17 commented Oct 25, 2016

@luixxiul - this is what i see now, what should i also see? thanks!
1

@willy-b
Copy link
Contributor

willy-b commented Oct 25, 2016

@mrose17, I think @luixxiul means to add the button to the 'Recover your wallet' dialog, like this:
recover_from_file_anim

@mrose17
Copy link
Member

mrose17 commented Oct 25, 2016

i see, yes, that makes sense... thanks!

@mrose17 mrose17 added this to the 1.1.0 milestone Oct 25, 2016
@willy-b
Copy link
Contributor

willy-b commented Oct 25, 2016

No problem!
(N.B. I got the label wrong -- I put "Recover from file" where @luixxiul spec'd "Import recovery keys")

@willy-b
Copy link
Contributor

willy-b commented Oct 26, 2016 •
edited
Loading

FYI, I just pushed an impl of this to a branch in my fork, will open a PR ~~~once I have a test.~~~ (EDIT: general recovery / backup tests are missing and other Advanced Panel tests are failing, so recommend adding/fixing Advanced Panel tests as a separate item unless advised otherwise)

@luixxiul
Copy link
Contributor Author

@willy-b "Recover from file" sounds more natural :-)

@willy-b willy-b mentioned this issue Nov 23, 2016
Merged
4 tasks
cezaraugusto pushed a commit that referenced this issue Jan 9, 2017
@cezaraugusto
Add "Import recovery keys" button to Payments->Advanced->Recover
3b6cbb9 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
@bsclifton bsclifton modified the milestones: 0.13.1, 1.1.0 Jan 12, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 12, 2017 •
edited by luixxiul
Loading

Fixed with #5809 which was merged into branch 0.13.1-branch.

Test Plan:

  1. Open Preferences->Payments

-- backup your wallet to a file --
2. Click "Advanced Settings..."
3. Click "Backup your wallet"
4. Click "Save recovery file..."
5. Choose a location / filename for your backup from the File Chooser dialog

-- recover your wallet from file --
6. Return to Preferences -> Payments (Close all modals)
7. Open "Advanced Settings..."
8. Click "Recover your wallet"
9. Click "Import recovery keys"
10. Use File Chooser dialog to select the backup file created previously (step 5)
11. Observe "Success" screen

bsclifton pushed a commit that referenced this issue Jan 14, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
5721182 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
073d0e2 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
af9d4f3 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
a861abd 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 20, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
55ccacd 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@NejcZdovc
Add "Import recovery keys" button to Payments->Advanced->Recover
a3f5955 
(opens a file chooser dialog)

fixes brave#4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes brave#6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 23, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
69040ce 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 24, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
30ace6c 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
0c8ff37 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
7bffa13 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Feb 3, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
6 participants
@mrose17 @alexwykoff @luixxiul @bsclifton @willy-b @srirambv