Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about pages logged in history by bookmarking them #4900

Closed
luixxiul opened this issue Oct 18, 2016 · 7 comments
Closed

about pages logged in history by bookmarking them #4900

luixxiul opened this issue Oct 18, 2016 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 18, 2016

Describe the issue you encountered: about pages are logged in the history by bookmarking them.

Expected behavior: They should be avoided from being logged in the history.

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X
  • Brave Version: master branch
  • Steps to reproduce:
    1. Clear your brave folder
    2. Open a new tab
    3. Bookmark it via the star button
    4. Click "New Tab" on the bookmark toolbar
    5. Open another new tab

And you will get this:

screenshot 2016-10-19 0 26 38

The star icon is blank in the picture just because I have removed the bookmark, so please ignore it.

@luixxiul luixxiul added this to the 0.12.6dev milestone Oct 18, 2016
@luixxiul
Copy link
Contributor Author

@bsclifton would you please take this one?

@Sh1d0w
Copy link

Sh1d0w commented Oct 18, 2016

@luixxiul I can't reproduce this on latest master: http://webm.land/media/h2QG.webm

@bbondy bbondy modified the milestones: 0.12.7dev, 0.12.6dev Oct 18, 2016
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

moved to 0.12.7

@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

@luixxiul can you still reproduce this?

@bbondy bbondy removed this from the 0.12.7dev milestone Oct 24, 2016
@luixxiul
Copy link
Contributor Author

no, it seems it has been fixed, closing.

@Sh1d0w
Copy link

Sh1d0w commented Oct 26, 2016

Just checkouted the latest master af38d76

Here is a video how I reproduce this. Today is 26th of October, I only see entries from yesterday 25th of October when I navigate:

http://webm.land/media/Kgjk.webm

@Sh1d0w Sh1d0w reopened this Oct 26, 2016
@Sh1d0w
Copy link

Sh1d0w commented Oct 26, 2016

Whops this is related to another ticket. Sorry. #4794

@Sh1d0w Sh1d0w closed this as completed Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants