Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autocomplete does not add history entries #4794

Closed
Sh1d0w opened this issue Oct 14, 2016 · 6 comments
Closed

Autocomplete does not add history entries #4794

Sh1d0w opened this issue Oct 14, 2016 · 6 comments
Labels
bug feature/history regression stale

Comments

@Sh1d0w
Copy link

Sh1d0w commented Oct 14, 2016

Did you search for similar issues before submitting this one?

No.

Describe the issue you encountered:

Using autocomlete to open pages does not add entries to the history.

Expected behavior:

Every page should be logged in the history with its last access time.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Fedora 24
  • Brave Version: 0.12.5-1
  • Steps to reproduce:
    1. Use autocomplete to navigate to page
    2. Inspect history

http://webm.land/media/QHH0.webm

  • Any related issues:
@Sh1d0w Sh1d0w added this to the 0.12.5dev milestone Oct 14, 2016
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev, 0.12.7dev Oct 15, 2016
@aekeus
Copy link
Member

aekeus commented Oct 24, 2016

I can confirm this is working in latest release. Closing now - please re-open if behaviour shows up again.

@aekeus aekeus closed this as completed Oct 24, 2016
@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 25, 2016

Sorry, it is still not working for me on the latest master f37459c on Fedora 24 . Followed the same steps from the video this morning and I can only see history entries from yesterday.

@Sh1d0w Sh1d0w reopened this Oct 25, 2016
@bbondy bbondy modified the milestones: 0.12.8dev, 0.12.7dev Oct 26, 2016
@Sh1d0w Sh1d0w mentioned this issue Oct 26, 2016
Closed
@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 26, 2016

Here is a video from latest master af38d76

http://webm.land/media/Kgjk.webm

This was referenced Oct 27, 2016
Closed
Closed
@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Oct 31, 2016
@bsclifton
Copy link
Member

Removing from 0.12.9 milestone (deadline: EOD today)

@bsclifton bsclifton removed this from the 0.12.9dev milestone Nov 8, 2016
@Sh1d0w Sh1d0w mentioned this issue Nov 10, 2016
Closed
@bsclifton bsclifton self-assigned this Nov 11, 2016
@bsclifton bsclifton added this to the 0.12.10 release milestone Nov 11, 2016
@bsclifton bsclifton mentioned this issue Nov 11, 2016
Closed
4 tasks
@bsclifton bsclifton removed their assignment Nov 14, 2016
@bsclifton bsclifton removed this from the 0.12.10 release milestone Nov 14, 2016
@luixxiul luixxiul added the bug label Nov 14, 2016
@cezaraugusto cezaraugusto mentioned this issue Nov 16, 2016
Closed
@bsclifton
Copy link
Member

Closing as history shows great for me and this issue is likely stale. Please do re-open if issue reoccurs

cc: @aekeus

@luixxiul luixxiul added the stale label May 12, 2017
@aekeus
Copy link
Member

aekeus commented May 12, 2017

Thanks for triaging this @bsclifton

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/history regression stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

History fixes and misc about page fixes
5 participants
@aekeus @bbondy @luixxiul @bsclifton @Sh1d0w