This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
History fixes and misc about page fixes #5559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This PR is going to conflict with #5531 and will need a rebase (since that PR will be accepted first) Also, tests are included and it appears all relevant ones passed when run locally (some of the pending tests are tracked with #5389; not all of the tests are triaged yet) |
This was referenced Nov 11, 2016
- History code was refactored - one step forward with regard to #3502 - session helper created for aboutHistory (tests added) - history specific methods broke out into historyUtil (tests added) - history stores it's data in AppStore.about.history (similar structure to new tab code) - about:history is only updated when something changed - # calls to render on about:history is drastically reduced (should fix #5382; please reopen if not) - entries are added on visit (as expected) and show on about:history instantly - Fixes #5542 - Fixes #4794 - Fixes #5072 - about:brave text update Implements followup feedback for #5436 (comment) Auditors: @cezaraugusto, @darkdh Test Plan: 1. Launch Brave and go to about:history 2. With history open, open a new tab and visit a site you have never been to before (hint: just append #1234567 to the end of URL) 3. Switch back to history tab and confirm entry shows 4. Open another new tab; in the URL bar, type an entry for a site you HAVE been to before (which shows in the autocomplete) 5. Instead of hitting enter, pick the URL from the autocomplete drop down (use arrow keys and press enter, OR click) 6. Visit about:history again and confirm this entry shows 7. On about:history, click some of the entries. They should show their selection status in a faster manner than before Advanced test notes: - After exiting Brave, you can view the session file to confirm the details used in about:history and about:brave are removed and NOT stored to disk
Fixes #5497 Auditors: @bradleyrichter Test Plan: 1. Launch Brave and visit about:about 2. Open each of the links and confirm it's the `fa-list` icon
|
@cezaraugusto noticed that during his testing that the history issue is not resolved. I tried after rebasing and was able to repro. Will be looking into that (please don't merge yet) |
darkdh
reviewed
Nov 11, 2016
| .sort(sortTimeDescending) | ||
| .slice(-aboutHistoryMaxEntries) | ||
| sites = makeImmutable(sites) || new Immutable.Map() | ||
| return sites.toList() |
|
@bradleyrichter screenshot (with description) added 😄 |
|
Closing this for now so that it doesn't accidentally get merged. Will either reopen or submit a new PR once it's ready for review again 😄 |
|
It looks like our icons are riding high for some reason. But this will look nice. |
4 tasks
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).The big history-fixer-upper
History code was refactored
about:history is only updated when something changed
about:brave text update
Implements followup feedback for Add basic styles to about:about and created page w/ version information (about:brave) #5436 (comment)
Auditors: @cezaraugusto, @darkdh
Test Plan:
Advanced test notes:
Remove unnecessary/broken/useless context menu items for about pages
Fixes #4812
Update icon for about pages to fa-list (except for about:newtab)
Fixes #5497
Auditors: @bradleyrichter
Test Plan:
fa-listiconScreenshots
Here's one showing: