Add basic styles to about:about and created page w/ version information (about:brave) #5436

bsclifton · 2016-11-06T09:34:18Z

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Add basic styles and version information to about:about

Fixes #463

Auditors: @bbondy, @bradleyrichter

Test Plan

Launch Brave and visit about:about
Pull up versions from the "About Brave" message box: Help > About Brave (or on Mac, Brave > About Brave)
Compare the versions shown on the about:about page to the ones in the message box

Screenshots

The new look

Text is really easy to select for copy/paste

compare this to the current look

bbondy · 2016-11-07T14:18:42Z

js/about/about.js

+    super()
+    this.state = { versionInformation: Immutable.fromJS([]) }
+    ipc.on(messages.VERSION_INFORMATION_UPDATED, (e, versionInformation) => {
+      console.log('got message')


nit remove logging

bbondy · 2016-11-07T14:18:49Z

js/about/about.js

+    ipc.on(messages.VERSION_INFORMATION_UPDATED, (e, versionInformation) => {
+      console.log('got message')
+      if (this.state.versionInformation.size === 0) {
+        console.log('updating')


nit: logging

bbondy · 2016-11-07T14:22:39Z

This is great, I don't mind about:about being combined either. Can you get rid of the dialog though from the about menu and make it go here instead? Test main menu locations and hamburger menu location.

bsclifton · 2016-11-07T16:54:27Z

Maybe once there's more about pages, we can break this out into it's own about:version page; my initial thought was that (with limited info) it makes sense to show as many details about Brave as possible in one place 😄 We could possibly add more info we find valuable for troubleshooting, like OS version, Video drivers, etc.

Working on the fixes now...

luixxiul · 2016-11-07T17:14:51Z

Wouldn't it nice if we display the additional version info like "RC1" or "preview1"?

bsclifton · 2016-11-07T17:34:08Z

Good call, @luixxiul! I captured that with #5462. For many reasons, it would be more useful to use the last SHA from git rather than an arbitrary string (one example: the release candidate gets renamed when accepted)

bsclifton · 2016-11-07T18:17:45Z

Updated!

@darkdh, if you have a moment, please check out the changes. There are two message boxes that were in app/aboutDialog.js which I moved into app/importer.js. They were being exported, but I changed them to local const because they're not used elsewhere. I tested an import to verify it loads (but didn't try the one w/ a warning).

@bbondy picking About Brave now brings you to the about page 😄 The previous message box has been removed

bsclifton · 2016-11-07T18:35:06Z

Here we go- even more useful info for debugging 😄

Muon being our fork of electron

darkdh · 2016-11-07T19:17:15Z

++ for the importer dialog, thx.

svg buttons alignment on tabsbar

bbondy · 2016-11-07T20:49:27Z

cc @bradleyrichter do we want to combine the about page with about:about? Note other browsers keep them separate and we might double or triple our about:about pages in the next year. I'm fine either way.

@bbondy

Removed app/aboutDialog.js, moved import methods over to `app/importer.js` Added os platform/release/arch and changed electron to muon :) Fixes #463 Auditors: @bbondy, @bradleyrichter, @darkdh (see changes to app/importer.js) Test Plan: 1. Launch Brave and visit about:about 2. Pull up version from Help > About Brave (or on Mac, Brave > About Brave) 3. Import bookmarks to ensure the message box shown there still works

@bbondy

Auditors: @bbondy

bsclifton · 2016-11-07T22:38:31Z

js/about/entry.js

+    break
+  case 'about:safebrowsing':
+    element = require('./safebrowsing')
+    break
  case 'about:styles':
    element = require('./styles')
    break


this is sorted alphabetical now

bsclifton · 2016-11-07T22:38:52Z

js/lib/appUrlUtil.js

-  'about:passwords': module.exports.getAppUrl('about-passwords.html'),
-  'about:flash': module.exports.getAppUrl('about-flash.html'),
-  'about:error': module.exports.getAppUrl('about-error.html'),
-  'about:autofill': module.exports.getAppUrl('about-autofill.html'),
  'about:styles': module.exports.getAppUrl('about-styles.html')


same here; alphabetical FTW 😛

bbondy · 2016-11-07T23:44:04Z

fancy with the sortable table 👍

bbondy · 2016-11-07T23:50:45Z

fannnntastic, thanks.

srirambv · 2016-11-08T14:05:36Z

@bsclifton doesn't brave/muon/channel/os needs to be capitalized??

bsclifton · 2016-11-08T16:02:49Z

@srirambv that is a good question! I didn't consider that- I'll do a follow up which fixes that 😄

bsclifton added the copy/content/text label Nov 6, 2016

bsclifton added this to the 0.12.9dev milestone Nov 6, 2016

bsclifton assigned bbondy and bradleyrichter Nov 6, 2016

bbondy reviewed Nov 7, 2016

View reviewed changes

jkup and others added 2 commits November 7, 2016 12:02

svg buttons alignment on tabsbar

5c800ec

Merge pull request #5468 from brave/svg-alignment

545b066

svg buttons alignment on tabsbar

bsclifton changed the title ~~Add basic styles and version information to about:about~~ Add basic styles to about:about and created page w/ version information (about:brave) Nov 7, 2016

Broke version information into it's own page (about:brave)

ce23b92

Auditors: @bbondy

bsclifton commented Nov 7, 2016

View reviewed changes

bsclifton force-pushed the master branch from 545b066 to 7ae7274 Compare November 7, 2016 23:10

bbondy merged commit 9bff90a into brave:master Nov 7, 2016

bsclifton deleted the about branch November 8, 2016 00:13

luixxiul mentioned this pull request Nov 10, 2016

Main window(s) stop responding if help about is open #2902

Closed

alexwykoff mentioned this pull request Nov 10, 2016

Manual tests for OS X 0.12.9 Preview1 #5548

Closed

This was referenced Nov 10, 2016

Manual tests for Windows x64 0.12.9 Preview1 #5549

Closed

Manual tests for Ubuntu 0.12.9 Preview1 #5550

Closed

bsclifton mentioned this pull request Nov 11, 2016

History fixes and misc about page fixes #5559

Closed

4 tasks

This was referenced Nov 14, 2016

Manual tests for OS X 0.12.9 Preview 3 Per-release Items #5591

Closed

Manual tests for Window x64 0.12.9 Preview 3 per-release items #5597

Closed

Manual tests for Ubuntu 0.12.9 Preview 3 per-release items #5598

Closed

bsclifton mentioned this pull request Nov 14, 2016

History fixes and misc about page fixes #5600

Merged

4 tasks

luixxiul mentioned this pull request Nov 14, 2016

Manual tests for Window ia-32 0.12.9 RC1 per-release items #5604

Closed

srirambv added the QA/checked-Win64 label Nov 14, 2016

luixxiul added the QA/checked-Win32 label Nov 15, 2016

alexwykoff added the QA/checked-macOS label Nov 15, 2016

srirambv added the QA/checked-Linux label Nov 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic styles to about:about and created page w/ version information (about:brave) #5436

Add basic styles to about:about and created page w/ version information (about:brave) #5436

bsclifton commented Nov 6, 2016 •

edited

Loading

bbondy Nov 7, 2016

bbondy Nov 7, 2016

bbondy commented Nov 7, 2016

bsclifton commented Nov 7, 2016

luixxiul commented Nov 7, 2016

bsclifton commented Nov 7, 2016 •

edited

Loading

bsclifton commented Nov 7, 2016 •

edited

Loading

bsclifton commented Nov 7, 2016 •

edited

Loading

darkdh commented Nov 7, 2016

bbondy commented Nov 7, 2016

bsclifton Nov 7, 2016

bsclifton Nov 7, 2016

bbondy commented Nov 7, 2016

bbondy commented Nov 7, 2016

srirambv commented Nov 8, 2016

bsclifton commented Nov 8, 2016

Add basic styles to about:about and created page w/ version information (about:brave) #5436

Add basic styles to about:about and created page w/ version information (about:brave) #5436

Conversation

bsclifton commented Nov 6, 2016 • edited Loading

Test Plan

Screenshots

bbondy Nov 7, 2016

Choose a reason for hiding this comment

bbondy Nov 7, 2016

Choose a reason for hiding this comment

bbondy commented Nov 7, 2016

bsclifton commented Nov 7, 2016

luixxiul commented Nov 7, 2016

bsclifton commented Nov 7, 2016 • edited Loading

bsclifton commented Nov 7, 2016 • edited Loading

bsclifton commented Nov 7, 2016 • edited Loading

darkdh commented Nov 7, 2016

bbondy commented Nov 7, 2016

bsclifton Nov 7, 2016

Choose a reason for hiding this comment

bsclifton Nov 7, 2016

Choose a reason for hiding this comment

bbondy commented Nov 7, 2016

bbondy commented Nov 7, 2016

srirambv commented Nov 8, 2016

bsclifton commented Nov 8, 2016

bsclifton commented Nov 6, 2016 •

edited

Loading

bsclifton commented Nov 7, 2016 •

edited

Loading

bsclifton commented Nov 7, 2016 •

edited

Loading

bsclifton commented Nov 7, 2016 •

edited

Loading