Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

svg buttons alignment on tabsbar #5468

Merged
merged 1 commit into from
Nov 7, 2016
Merged

svg buttons alignment on tabsbar #5468

merged 1 commit into from
Nov 7, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 7, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5456

Auditors @bsclifton @luixxiul

Test Plan:

  1. Open Brave
  2. Create new tabs until you've filled up the tabs row
  3. Make sure the + for the new tab button lines up with the kabob three dots for menu.
  4. Three dots should be dark gray and turn black on hover.

Screenshots for @bradleyrichter's approval

screen shot 2016-11-07 at 12 01 54 pm

and hover

screen shot 2016-11-07 at 12 02 00 pm

@jkup jkup added design A design change, especially one which needs input from the design team. QA/test-plan-specified labels Nov 7, 2016
@jkup jkup added this to the 0.12.10 release milestone Nov 7, 2016
@bsclifton bsclifton modified the milestones: 0.12.9dev, 0.12.10 release Nov 7, 2016
@bsclifton
Copy link
Member

Looks great, thanks! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants