Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab is not bookmarked by dragging on the bookmark folder #5193

Closed
luixxiul opened this issue Oct 27, 2016 · 5 comments
Closed

tab is not bookmarked by dragging on the bookmark folder #5193

luixxiul opened this issue Oct 27, 2016 · 5 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks misc/drag-and-drop wontfix

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: The tab is not bookmarked by dragging it on the bookmark folder on the toolbar. For now it needs to be dragged and dropped to the pulldown. Also the color of the dragged tab remains changed.

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.7 RC1
  • Steps to reproduce:
    bookmark
  • Any related issues:
@luixxiul luixxiul added this to the 0.12.7dev milestone Oct 27, 2016
@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

I don't think we ever supported dragging tabs to bookmarks toolbar and actually I think tear off tabs will override this functionality, Chrome doesn't allow it but Firefox does. It doesn't need to be prioritized in any case though.

@bbondy bbondy removed this from the 0.12.7dev milestone Oct 28, 2016
@luixxiul
Copy link
Contributor Author

But the tab is bookmarked by dragging it on the bookmark folder pulldown like this.

bookmark

Doesn't it work as it should?

@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

interesting and I'm surprised :)

I think we can support it and work like firefox, but not super high priority I don't think. After tear o tabs for sure.

@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 7, 2017

FYI drag and drop to the folder still works but at the same time it detaches the tab.

@bsclifton bsclifton added addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix labels Aug 10, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 10, 2018
@bsclifton
Copy link
Member

Closing as wontfix; when moving to brave-core, this would no longer be feasible because dragging the tab detaches it immediately (into its own window)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks misc/drag-and-drop wontfix
Projects
None yet
Development

No branches or pull requests

4 participants