Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark and Bookmark folder cannot be dragged and dropped into another folder on the bookmark toolbar #11040

Closed
luixxiul opened this issue Sep 20, 2017 · 7 comments
Closed

Bookmark and Bookmark folder cannot be dragged and dropped into another folder on the bookmark toolbar #11040

luixxiul opened this issue Sep 20, 2017 · 7 comments
Assignees
@bbondy
Labels
bug feature/navbar misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 20, 2017 •
edited
Loading

Description

Bookmark folder cannot be moved into another folder on the bookmark toolbar.

Steps to Reproduce

  1. Display the bookmark toolbar
  2. Create two empty bookmark folders
  3. Drag the one and drop onto the other

Actual result: The bookmark folder is not moved.

bug

Expected result: It should be moved.

Reproduces how often: [What percentage of the time does it reproduce?]
Always

Brave Version

Brave: 0.19.7
rev: c8481a9
Muon: 4.4.16
libchromiumcontent: 61.0.3163.71
V8: 6.1.534.31
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Linux
OS Release: 4.9.0-3-amd64
OS Architecture: x64

The issue cannot be reproduced on the latest 0.18.

Additional Information

Found during QA on #9712. Also the bookmark folders can be drag and dropped each other on the bookmarks manager.

#11033 #11034
@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Sep 20, 2017
@luixxiul luixxiul changed the title Bookmark folder cannot be draged and dropped into another folder on the bookmark toolbar Bookmark folder cannot be dragged and dropped into another folder on the bookmark toolbar Sep 20, 2017
@LaurenWags
Copy link
Member

I'm also unable to drag/drop a bookmark on the toolbar to a folder on the toolbar:
bookmarktoolbardnd

@NejcZdovc
Copy link
Contributor

@LaurenWags you need to drop it on empty item

@NejcZdovc
Copy link
Contributor

more info here #5193

@LaurenWags
Copy link
Member

@NejcZdovc i'm not dragging and dropping tabs though, i'm drag/drop bookmarks on the toolbar to a folder on the toolbar. this works in 0.18.36:
bkmktoolbar01836

@NejcZdovc
Copy link
Contributor

I didn't know that this is working :D

@LaurenWags
Copy link
Member

it was before, is not now :(

@LaurenWags LaurenWags mentioned this issue Sep 20, 2017
Closed
@LaurenWags LaurenWags changed the title Bookmark folder cannot be dragged and dropped into another folder on the bookmark toolbar Bookmark and Bookmark folder cannot be dragged and dropped into another folder on the bookmark toolbar Sep 20, 2017
@bbondy bbondy closed this as completed in 0c0524c Sep 21, 2017
bbondy added a commit that referenced this issue Sep 21, 2017
@bbondy
Fix drag bookmark into folder
5ca3af8 
Fix #11040

Auditors: @NejcZdovc
bbondy added a commit that referenced this issue Sep 21, 2017
@bbondy
Fix drag bookmark into folder
c53fc24 
Fix #11040

Auditors: @NejcZdovc
@bbondy
Copy link
Member

bbondy commented Sep 21, 2017

0.19.x: 5ca3af8
0.20.x: c53fc24
master: 0c0524c (This one also includes an unrelated fix on master for drag and drop not updating the bookmarks toolbar)

@bbondy bbondy self-assigned this Sep 21, 2017
This was referenced Sep 22, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Sep 26, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
bbondy added a commit that referenced this issue Oct 3, 2017
@bbondy
Remove unused code from #11040
9cfeae0 
Auditors: @NejcZdovc
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Fix bookmark drag and drop after order cache changes
a00fde7 
Fix brave#11040

Auditors: @NejcZdovc
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Remove unused code from brave#11040
91d329c 
Auditors: @NejcZdovc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
bug feature/navbar misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags