This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
"Top Sites" should consider visit count when ordering #5322
Assignees
Milestone
Comments
4 tasks
bbondy
pushed a commit
that referenced
this issue
Nov 14, 2016
Bookmarking items does not affect position Fixes #5413 Sites are ordered by most visited (count) DESC Fixes #5322 Groundwork laid for #5565, but the task is unfinished as-is. ----- These commits moving existing logic from newtab.js into the session helper. Tests were then added and I manually tested each scenario and tried to make sure tests cover those. Things which are not covered are marked with TODO(bsclifton) The important thing: appState.about.newtab.sites no longer persists a separate copy of the sites array. It instead uses the location/partion of items saved to lookup the real object from appState.sites. ----- Auditors: @cezaraugusto, @bbondy
This was referenced Nov 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
"Top Sites" should consider the visit count when ordering. This is available in the siteDetail object as "count".
The text was updated successfully, but these errors were encountered: