Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

the bookmark hanger being faded in #6380

Closed
luixxiul opened this issue Dec 22, 2016 · 1 comment
Closed

the bookmark hanger being faded in #6380

luixxiul opened this issue Dec 22, 2016 · 1 comment
Assignees
@luixxiul
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 22, 2016 •
edited
Loading

Test plan

  1. Click the star icon on the URL bar
  2. Make sure the bookmark dialog is prompted without animation

Describe the issue you encountered:
#6326 (comment)

My bad, this causes the bookmark hanger being faded in. Will push a fix.

Expected behavior: it should not fade in
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 22, 2016
@luixxiul luixxiul self-assigned this Dec 22, 2016
@luixxiul luixxiul mentioned this issue Dec 22, 2016
Closed
4 tasks
@luixxiul luixxiul removed their assignment Dec 22, 2016
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 22, 2016
@alexwykoff alexwykoff added this to the 0.13.1 milestone Dec 22, 2016
@luixxiul luixxiul mentioned this issue Jan 20, 2017
Closed
@bbondy bbondy modified the milestones: 0.13.3, 0.13.2 Feb 1, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented May 6, 2017

This has been fixed with #8443 (#8136)

@luixxiul luixxiul closed this as completed May 6, 2017
@luixxiul luixxiul added this to the 0.15.3 milestone May 6, 2017
@luixxiul luixxiul self-assigned this May 6, 2017
@alexwykoff alexwykoff mentioned this issue May 23, 2017
Closed
53 tasks
@alexwykoff alexwykoff mentioned this issue May 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv