This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed the bookmark hanger being faded in #6382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@jkup would you be able to check this one out? If it looks good, let's mark with a |
|
Not crazy about that selector, it's a bit tough to read. If we're going to keep the wildcard + :not selector can we at least add a comment that says something like: /* Animate all direct descendants except for the bookmark bar */ Just something to make it easier for the next dev to understand! Otherwise ++ |
|
ok updated, thanks. |
|
thanks @luixxiul ++ |
bsclifton
force-pushed
the
0.13.1-branch
branch
from
4abf18d
to
e29888d
Compare
|
I'll rebase |
Fixes #6380 Auditors: Test Plan: 1. Bookmark a page with the star icon on the URL bar 2. Make sure that "Bookmark Added" dialog is instantly displayed without animation
|
I close this PR since it doesn't use Aphrodite: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6380
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).unintentionally I broke the animation. I've been not sure that the bookmark dialog was included in #navigator.