Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

wallet preference page is not refreshing itself when a bitcoin handler is registered #6770

Closed
alexwykoff opened this issue Jan 20, 2017 · 5 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jan 20, 2017

Test plan

From #7443 (comment)

  1. clear your session, open brave
  2. open preferences, create a wallet
  3. in a new tab, visit https://jsfiddle.net/LnwtLckc/5/, click on register
  4. switch tabs back to preferences, check add funds modal, 'transfer btc' button should now show

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When executing the ledger regression tests, it was found that https://jsfiddle.net/LnwtLckc/5/ did not appear to have registered appropriately. Upon further investigation, it was discovered that the real issue was that the preference page was not updating when the handler was being registered/unregistered like it had in prior releases.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version (revision SHA):
    0.13.0 Preview 10 (c60b783)

  • Steps to reproduce:

    1. clear your session, open brave
    2. open preferences, create a wallet
    3. in a new tab, visit https://jsfiddle.net/LnwtLckc/5/, click on register
    4. switch tabs back to preferences, check add funds modal, notice lack of 'transfer btc' button
  • Actual result:
    'transfer btc' button does not appear in the modal

  • Expected result:
    'transfer btc' button should appear in the modal

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    btc_handler

  • Any related issues:

@luixxiul
Copy link
Contributor

luixxiul commented Jan 21, 2017

Confirmed on 0.13.0 RC4 on Windows 10 32 bit

@mrose17
Copy link
Member

mrose17 commented Jan 27, 2017

the issue appears to be that updateAboutDetails is invoked when a tab is created, but not when you switch to it.

looking at earlier versions, e.g., https://github.com/brave/browser-laptop/blob/0_12_14_release_notes/js/components/frame.js#L93 it looks like a looser test was used.

@bbondy - git blame suggests that i ask you about the intent here. thanks!

@bbondy
Copy link
Member

bbondy commented Jan 27, 2017

howdy mrose, you'll have to pass in props for if it's registered, I'm a bit concerned about a perf problem here though. Maybe we should add an event when a protocol is registered and handle it? @bridiver

@mrose17 mrose17 modified the milestones: 0.13.2, 0.13.1 Jan 27, 2017
@mrose17
Copy link
Member

mrose17 commented Jan 27, 2017

@bbondy - i am sensitive to the performance issue. since this code is 90% browser internals and 10% ledger-related, i'd like to have it re-assigned to someone who knows the internals and can make a performant/correct fix.

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@bbondy bbondy added this to the 0.13.6 milestone Feb 22, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 2, 2017
@bsclifton bsclifton modified the milestones: 0.13.5, 0.13.6 Mar 2, 2017
bsclifton added a commit that referenced this issue Mar 2, 2017
Fixed wallet preference page refresh
@srirambv
Copy link
Collaborator

srirambv commented Mar 3, 2017

Working on 0.13.5 RC3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.